JS - 初学者 - function isMaleName()

Question

In polish language most of the female name end in letter "a", which help to quickly identify the gender. Except is "Bonawentura" which is male name.

I need to write function which will tell:

• if male name - true
• if female name - false
• if "Bonawentura" - true

This is what I did: example 1:

function isMaleName(name) {
  let pieces = name.split("");
  let last = pieces[pieces.length - 1];
  if ((name = "bonawentura")) {
    return true;
  } else if ((last = "a")) {
    return false;
  } else {
    return true;
  }
}

2 conditions complete:

• if male name - true
• if "Bonawentura" - true

example 2:

function isMaleName(name) {
  let pieces = name.split("");
  let last = pieces[pieces.length - 1];
  if ((last = "a")) {
    return false;
  } else {
    return true;
  }
}

1 condition complete:

• if female name - false

Answer 1

You are assigning a Value instead of checking it.
You should use name == "bonawentura" instead of name = "bonawentura"

Answer 2

function isMaleName(name) {
    let pieces = name.split("");
    let last = pieces[pieces.length - 1];
    if (name === "bonawentura") {
      return true;
    } else if (last === "a") {
      return false;
    } else {
      return true;
    }
  }

I think it should be look like this, use two or three = instead of using one = .

Answer 3

You can use = operator it's use to store value in variable, but if you use == it's for equality operator and if you can use === it is identity operator

Your problem is:

if ((name = "bonawentura"))
if ((last = "a"))

Use this code in if condition

if ((name == "bonawentura"))
if ((last == "a"))

Or

if ((name === "bonawentura"))
if ((last === "a"))

Answer 4

You could do it in one line, and support lowercase/uppercase/boNAweNtura :

 const isMaleName = name => !name.endsWith("a") || name.toLowerCase()==="bonawentura"; console.log(isMaleName("Joe")) // true console.log(isMaleName("Lena")) // false console.log(isMaleName("boNAweNtura")) // true console.log(isMaleName("David")) // true console.log(isMaleName("Sara")) // false

Answer 5

My comment above was maybe a bit misleading. So here in full:

function isMaleName(name) {
  // convert input to lowercase
  name = name.toLowerCase();

  // check if it's the fixed string 'bonawentura'
  return name === 'bonawentura'
      // if not, check if it not ends with an 'a'.
      || 'a' !== name[name.length - 1];
}

Refs:

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String#character_access
• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toLowerCase