How to edit other user's name in a Ruby on Rails application?

Question

class UsersController < ApplicationController
  
    before_action :user_logged_in, only: [:edit ,:update, :destroy]
    before_action :check_admin, only: [:index]
    before_action :check_correct_user, only: [:edit ,:update] 


    def edit

    @user=User.find(params[:id])
    
    end


    def update
    @user=User.find(params[:id])
    if @user.update(user_req)
    flash[:success]="Profile Updated"
    redirect_to users_path 
    else
        render 'edit'
    end
   end 


   private



   def user_req
        
params.require(:user).permit(:name,:email,:password,:password_confirmation)
   end



    def check_admin
    
    redirect_to(root_url) unless current_user.admin?
    flash[:danger]="Only admin can see users"
    
  
    end

    def check_correct_user
      @user = User.find(params[:id])
      redirect_to(root_url) unless @user == current_user and current_user.admin?
    end

myindex

<%= provide(:title, "All users") %>

List of all users

<ol>
   
<%= render @users %>

</ol>

my user.html.erb

 <%= link_to user.name, user %> <% if current_user.admin? %> <%= link_to "delete this user",user, method: :delete, data:{confirm:"Do you want to delete this?"} %> <%= link_to "Update Profile",edit_user_path() %> <%end%>

Answer 1

As suggested in the comments, you have a check that prevents users from editing other users, specifically this part:

def check_correct_user
  @user = User.find(params[:id])
  redirect_to(root_url) unless @user == current_user and current_user.admin?
end

So, as it stands, you can only edit your own profile if you are an admin . If you want users to be able to edit their own profile as well as allow admins to edit any profile then you should change your check to an OR statement:

@user == current_user || current_user.admin?

Edit

Views

<%= link_to "Update Profile",edit_user_path(user) %>