Python战舰，麻烦加倍

Question

为什么它会问你两次要把战舰放在哪里？ 我不知道该怎么做。

无论如何，在此链接中您都可以看到完整的代码，因为我不知道这是否必要。 http://speedy.sh/QYJWp/battleship-goed.txt

我认为问题发生在//_________________________________________________________//部分之前

    board1 = []
    board2 = []


    for x in range(10):
        board1.append(["O"] * 10)

    for x in range(10):
        board2.append(["O"] * 10)

    def print_board1(board):
        for row in board:
            print " ".join(row)
    def print_board2(board):
        for row in board:
            print " ".join(row)

    print "Board User 1"
    print_board1(board1)
    print "----------------------------------------------"
    print "Board User 2"
    print_board2(board2)

    print "Let's play Battleship!"
    print "Try to destroy all your opponents battleship!"
    print"Good luck!"
    print " "
    print " "


    def U1_Input_row1(board1):
                x = float(raw_input("User 1, in what row do you want to place your first ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_row1(board1)

    def U1_Input_col1(board1):
                x = float(raw_input("User 1, in what col do you want to place your first ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_col1(board1)

    ship1 = [U1_Input_row1(board1), U1_Input_col1(board1)] 

    def U1_Input_row2(board1):
                x = float(raw_input("User 1, in what row do you want to place your second ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_row2(board1)

    def U1_Input_col2(board1):
                x = float(raw_input("User 1, in what col do you want to place your second ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_col2(board1)

    ship2 = [U1_Input_row2(board1), U1_Input_col2(board1)]

    def U1_Input_row3(board1):
                x = float(raw_input("User 1, in what row do you want to place your third ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_row3(board1)

    def U1_Input_col3(board1):
                x = float(raw_input("User 1, in what col do you want to place your third ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_col3(board1)

    ship3 = [U1_Input_row3(board1), U1_Input_col3(board1)]

    def U1_Input_row4(board1):
                x = float(raw_input("User 1, in what row do you want to place your fourth ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_row4(board1)

    def U1_Input_col4(board1):
                x = float(raw_input("User 1, in what col do you want to place your fourth ship?"))
                if x > 0 and x < 11 and x%1 == 0:
                    return x - 1
                else:
                    print "Please enter an integer and a number between 1 and 10"
                    U1_Input_col4(board1)

    ship4 = [U1_Input_row4(board1), U1_Input_col4(board1)] 

    if ship1 == ship2 or ship1 == ship3 or ship1 == ship4 or ship2 == ship3 or ship2 == ship4 or ship3 == ship4:
                print "YOU CANT PLACE 2 SHIPS IN THE SAME SPOT"
                U1_Input_row1(board1)
                U1_Input_col1(board1)
                U1_Input_row2(board1)
                U1_Input_col2(board1)
                U1_Input_row3(board1)
                U1_Input_col3(board1) 
                U1_Input_row4(board1) 
                U1_Input_col4(board1) 


    def U2_Input_row1(board2):
        x = float(raw_input("User 2, in what row do you want to place your first ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_row1(board2)

    def U2_Input_col1(board2):
        x = float(raw_input("User 2, in what col do you want to place your first ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_col1(board2)

    ship1u2 = [U2_Input_row1(board1), U2_Input_col1(board1)] 

    def U2_Input_row2(board2):
        x = float(raw_input("User 2, in what row do you want to place your second ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_row2(board2)

    def U2_Input_col2(board2):
        x = float(raw_input("User 2, in what col do you want to place your second ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_col2(board2)

    ship2u2 = [U2_Input_row2(board1), U2_Input_col2(board1)]

    def U2_Input_row3(board2):
        x = float(raw_input("User 2, in what row do you want to place your third ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_row3(board2)

    def U2_Input_col3(board2):
        x = float(raw_input("User 2, in what col do you want to place your third ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_col3(board2)

    ship3u2 = [U2_Input_row3(board1), U2_Input_col3(board1)]

    def U2_Input_row4(board2):
        x = float(raw_input("User 2, in what row do you want to place your fourth ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_row4(board2)

    def U2_Input_col4(board2):
        x = float(raw_input("User 2, in what col do you want to place your fourth ship?"))
        if x > 0 and x < 11 and x%1 == 0:
            return x - 1
        else:
            print "Please enter an integer and a number between 1 and 10"
            U2_Input_col4(board2)

    ship4u2 = [U2_Input_row4(board1), U2_Input_col4(board1)]

    if ship1u2 == ship2u2 or ship1u2 == ship3u2 or ship1u2 == ship4u2 or ship2u2 == ship3u2 or ship2u2 == ship4u2 or ship3u2 == ship4u2:
                print "YOU CANT PLACE 2 SHIPS IN THE SAME SPOT"
                U2_Input_row1(board2)
                U2_Input_col1(board2)
                U2_Input_row2(board2)
                U2_Input_col2(board2)
                U2_Input_row3(board2)
                U2_Input_col3(board2) 
                U2_Input_row4(board2) 
                U2_Input_col4(board2)


    U1_Input_row1 = U1_Input_row1(board1)
    U1_Input_col1 = U1_Input_col1(board1)
    U1_Input_row2 = U1_Input_row2(board1)
    U1_Input_col2 = U1_Input_col2(board1)
    U1_Input_row3 = U1_Input_row3(board1)
    U1_Input_col3 = U1_Input_col3(board1)
    U1_Input_row4 = U1_Input_row4(board1)
    U1_Input_col4 = U1_Input_col4(board1)
    U2_Input_row1 = U2_Input_row1(board2)
    U2_Input_col1 = U2_Input_col1(board2)
    U2_Input_row2 = U2_Input_row2(board2)
    U2_Input_col2 = U2_Input_col2(board2)
    U2_Input_row3 = U2_Input_row3(board2)
    U2_Input_col3 = U2_Input_col3(board2)
    U2_Input_row4 = U2_Input_row4(board2)
    U2_Input_col4 = U2_Input_col4(board2)

Answer 1

它询问两次，因为它遍历脚本并在函数之间命中它们：

ship1 = [U1_Input_row1(board1), U1_Input_col1(board1)]
ship2 = [U1_Input_row2(board1), U1_Input_col2(board1)]
ship3 = [U1_Input_row3(board1), U1_Input_col3(board1)]
ship4 = [U1_Input_row4(board1), U1_Input_col4(board1)]
ship1u2 = [U2_Input_row1(board1), U2_Input_col1(board1)]
ship2u2 = [U2_Input_row2(board1), U2_Input_col2(board1)]
ship3u2 = [U2_Input_row3(board1), U2_Input_col3(board1)]
ship4u2 = [U2_Input_row4(board1), U2_Input_col4(board1)]

然后最后，它们通过这些调用再次请求输入：

U1_Input_row1 = U1_Input_row1(board1)
U1_Input_col1 = U1_Input_col1(board1)
U1_Input_row2 = U1_Input_row2(board1)
U1_Input_col2 = U1_Input_col2(board1)
U1_Input_row3 = U1_Input_row3(board1)
U1_Input_col3 = U1_Input_col3(board1)
U1_Input_row4 = U1_Input_row4(board1)
U1_Input_col4 = U1_Input_col4(board1)
U2_Input_row1 = U2_Input_row1(board2)
U2_Input_col1 = U2_Input_col1(board2)
U2_Input_row2 = U2_Input_row2(board2)
U2_Input_col2 = U2_Input_col2(board2)
U2_Input_row3 = U2_Input_row3(board2)
U2_Input_col3 = U2_Input_col3(board2)
U2_Input_row4 = U2_Input_row4(board2)
U2_Input_col4 = U2_Input_col4(board2)

不过，该脚本的思想很差，因为大多数这些功能可能只是塞入单个功能中，以节省更少的代码行。

这将使用户感到烦恼，因为即使其中7/8可以，他也必须完成整个输入船位的过程。

if ship1u2 == ship2u2 or ship1u2 == ship3u2 or ship1u2 == ship4u2 or ship2u2 == ship3u2 or ship2u2 == ship4u2 or ship3u2 == ship4u2:

您还可以使用while语句继续询问用户是否输入了错误的内容。 现在完成的方式有点怪异。

如果用户输入一堆字母或其他内容，脚本将立即崩溃，因为在那里没有错误检查。 使用isdigit()可以帮助确定输入是否转换到前一个整数int和try except可以使用如果该字段被简单地留为空。

希望这会有所帮助:)

Answer 2

我看不到它将在哪里执行您所描述的操作，但是我认为您应该使用数组而不是ship1u1 ...这将使读取代码变得容易得多，并且可以节省几行代码。