使用Structures和pThreads时出现分段错误

Question

我一直在使用一个程序，该程序将读取多个文本文件，记录其中的单词数，并将所有单词和它们的出现频率写入文件。 但是，我在代码中的某处遇到了分段错误。 我尝试使用Valgrind等工具来帮助我调试它，但是它仅指向主循环中我说int i = 0的位置。 我为发布代码的大部分而表示歉意，但是我花了数小时试图找出错误所在，并且似乎无法终生发现。 当我开始在pthread_exit（）中传递结构时，问题就开始了。

#include <iostream>
#include <fstream>
#include <string>
#include <pthread.h>
#include <vector>
#include <algorithm>
#include <sstream>
#include <iterator>
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <cstdio>
using namespace std;

// Create a structure that we can store information in
typedef struct info{
    int words;
    string dictionary[500000];
} info;

// Counts the number of words in the text file so we know how big to make our array
int countWord(char *arg){
    char words[25000];
    int count = 0;

    ifstream check;
    check.open(arg);
    while(!check.eof()){
        check>>words;
        count++;
    }
    cout<<"Word Count: "<< count << '\n';
    check.close();
    return count;

}

// Checks to see if the word exists in our dictionary or not
int findWord(string array[], string target, int wordCount){
    for(int i = 0; i < wordCount; ++i){
        if(array[i] == target){
            return 1;
        }
    }
    return 0;
}


// Checks to see how many times a word is repeated
int checkWord(string array[], string target, int wordCount){
    int number = 0;
    for(int i = 0; i < wordCount; i++){
        if(array[i] == target){
            number++;
        }
    }
    return number;
}


void *threads(void *arg){
    info information;
    char *fileName = (char *)arg;
    ifstream myfile (fileName);
    string line;
    string fullText[15000];
    string dictionary[500000];
    int wordCount = countWord(fileName);
    int i = 0;
    int find;
    int check;
    int x = 0;
    int checkingStart = 0;


    // Opens and reads the file word by word removing any symbols that we dislike
    if (myfile.is_open()){
        while(myfile >> line){
            transform(line.begin(), line.end(), line.begin(), ::tolower);
            line.erase(remove(line.begin(), line.end(), ','), line.end());
            fullText[i] = line;
            i++;
        }
    }

    else cout << "Unable to Open the File";
    myfile.close();

    // Goes through and adds all the words to our dictionary
    for(i = 0; i < wordCount; ++i){
        find = findWord(dictionary, fullText[i], wordCount);
        if(find == 0){
            dictionary[x] = {fullText[i]};
            ++x;
            checkingStart = 1;
        }
    }

    // Sets each section of dictionary equal to the one in the structure
    for(i = 0; i < wordCount; ++i){
        information.dictionary[i] = dictionary[i];
    }

    // Sets words equal to word count and then passes the structure information out of the thread
    information.words = wordCount;
    pthread_exit(&information);
    return NULL;
}

int main(){
    int i = 0;
    int x = 0;
    int y = 0;
    int z = 0;
    int a = 0;
    int b = 0;
    int add = 0;
    int currentSize = 0;
    int checkingStart = 0;
    int wordCount;
    int find;
    string fullDictionary[500000];
    string dict[500000];
    ofstream writeFile;
    info information;
    char *fileName;
    char *fileList[2];
    pthread_t threadCount[2];
    int frequency[500000];
    int check;
    fileList[0] = "text1";
    fileList[1] = "text2";

    // Creates a loop that creates and joins threads for each text file
    for(a = 0; a < 1; ++a){
        fileName = fileList[a];
        pthread_create(&threadCount[a], NULL, threads, &fileName);
        pthread_join(threadCount[a], (void **)&information);
        wordCount = information.words;

        // Sets each part of dict equal to the same slot on info.dict
        for(b = 0; b < wordCount; ++b){
            dict[b] = information.dictionary[b];
        }

        // Adds to a complete list of all the text files added together
        for(y = 0, z = currentSize; z < wordCount; ++z, ++y){
            fullDictionary[z] = dict[y];
        }
        currentSize = (currentSize + wordCount);
    }

    // Goes through and adds all the words to our dictionary
        for(i = 0; i < wordCount; ++i){
            find = findWord(dict, fullDictionary[i], currentSize);
            if(find == 0){
                dict[x] = {fullDictionary[i]};
                cout << "Added the Word: " << fullDictionary[i] << "\n";
                add = 1;
                checkingStart = 1;
            }
            // Checks the number of times each word appears in the text file
            if(checkingStart == 1){
                    check = checkWord(fullDictionary, dict[x], wordCount);
                    frequency[x] = {check};

                }
            // Checks to see if it needs to move to the next open dictionary spot
            if(add == 1){
            ++x;
            add = 0;
                }
        }
return 0;
  }

Answer 1

这些是使程序正常运行所需的更改。

1）一个问题似乎是函数线程中变量的大小。 看起来每个产生的线程都有一些默认限制。 您可以阅读pthread_attr_setstacksize。 但是最简单的解决方案是减少线程中字符串的大小。因此，变量的大小就是为什么一旦调用线程函数就会产生分段错误。 正如上面的评论中已经提到的，使用vector / maps类将有助于减少对大型局部变量的需求。

2）返回变量必须是非局部变量，否则返回值不会使其成功返回。

3）刚注意到主循环（变量a）仅运行一次。 同样，一旦启动线程（pthread_create），循环就在等待加入。 这将导致线程的序列化。 可以先完成创建，然后再在单独的循环中调用连接。

更改如下。

功能上-线程

  info *information;  
  //changed to pointer
  // info information;                                                                                                                                                                                         
  char *fileName = (char *)arg;                                                                      
  ifstream myfile (fileName);                                                                        
  string line;                                                                                       
  string fullText[1500];                                                                                                                                                                                      
  string dictionary[5000];  
  // reduced size                                                                                                                                                                                   
  //string fullText[15000]; 
  //string dictionary[500000];   

.....

 information = new info;    // create an instance 

........

// change to pointer 
     information->dictionary[i] = dictionary[i];                                                                                                                                                              
  }                                                                                                  

  // Sets words equal to word count and then passes the structure information out of the thread      
  information->words = wordCount;                                                                                                                                                                             
  pthread_exit(information); // return pointer 

在功能上-主要

info *information; // change to pointer 

....

 for(a = 0; a < 2; ++a){      // loop to 2 

.....

pthread_create(&threadCount[a], NULL, threads, (void *)fileName);  // changed file name                               
// pthread_create(&threadCount[a], NULL, threads, &fileName);   



wordCount = information->words; // changed for pointer 
...

dict[b] = information->dictionary[b]  // changed for pointer      

编辑之后，您应该能够运行以调试其余功能。