越界越界？

Question

显然，我超出了我的数组范围。 每次尝试读取列时，都会出现“下标超出范围错误”。 试图调试它并在另一列中运行它，它绝对可行，但不适用于此特定列。 有什么提示吗？

Private Sub Form_Load()
    Dim curp, fname, lname1, lname2, gender As String, i, pos As Long, asciinum As String, f As Long, validar As Boolean, fechaNac As Date

    With Worksheets("sheet1")
        For f = 2 To Cells(.Rows.Count, "L").End(xlUp).Row
            curp = Cells(f, "L").Value2
            fname = Cells(f, "F").Value2
            lname1 = Cells(f, "I").Value2
            lname2 = Cells(f, "J").Value
            gender = Cells(f, "k").Value2
            fechaNac = Cells(f, "P").Value2
' works           validar = CheckFirstLetter(lname1, curp, 1, f)
' works           validar = CheckFirstVowel(lname1, curp, 2, f)
            validar = CheckFirstLetter(lname2, curp, 3, f)
'            validar = CheckFirstLetter(fname, curp, 4)
'            validar = CheckDate(fechaNac, curp, 5)
'            validar = CheckGender(gender, curp, 11)
'            validar = CheckConsonant(lname1, curp, 12, 2)
'            validar = CheckConsonant(lname2, curp, 13, 2)
'            pos = posVowel(fname)
'            validar = CheckConsonant(fname, curp, 14, pos)
            If (validar = True) Then
            Cells(f, "N") = "Valido"
            Else: Cells(f, "N") = "No Valido"
            End If
        Next f
    End With
End Sub

Function CheckFirstLetter(mystring, text, indexCurp, index) As Boolean
            Dim outStr, asciinum, vocal, vocal2 As String, ary As Variant, i As Long
            ary = Split(mystring, " ")
            vocal = LCase(ary(LBound(ary)))   Breaks in this line
            vocal2 = LCase(ary(UBound(ary)))
            If (vocal = "de" Or vocal = "del") Then
            vocal = vocal2
            End If
            outStr = LCase(Mid(text, indexCurp, 1))
            asciinum = LCase(Mid(vocal, 1, 1))
            Cells(index, "M") = vocal
            Cells(index, "O") = vocal2
            If (asciinum = outStr) Then
                CheckFirstLetter = True
                Else: CheckFirstLetter = False
                End If
End Function

2 lbound和ubound的原因是因为有时字符串的长度不同，我只想接受最后一个单词。 但是它在那个特定的空间上破裂了。 我猜是因为我没有指向正确的单元格？

谢谢！

Answer 1

我仔细检查并修复了一些损坏的东西。 每当您声明变量时，例如：

Dim SomeVariable1, SomeVariable2, SomeVariable3 as String

好像在说：

Dim SomeVariable1 as Variant, SomeVariable2 as Variant, SomeVariable3 as String

在同一行列出所有声明只会阻止您需要重复作用域，而不是类型。

此外，您还会执行以下操作：

Cells(f, "K").Value

但是，即使在With块中，该引用也不合格。 在这些之前放置一个时间以使它们合格。

最后，定义您的函数应具有的变量类型。

CheckFirstLetter(mystring, text, indexCurp, index) As Boolean

是相同的

CheckFirstLetter(mystring as Variant, text as Variant, indexCurp as Variant, index as Variant) As Boolean

这意味着我可以传递我想要的任何内容，并且不会有问题。 我怀疑您的子例程中的所有变体都是问题。 请参阅下面的固定代码：

Private Sub Form_Load（）Dim curp As String Dim fname As String Dim lname1 As String Dim lname2 As String Dim性别As String

Dim i As Long
Dim pos As Long
Dim asciinum As String
Dim f As Long ' Why jump back to f if you have i declared? It doesnt make a difference, but usually the next logical choice is j
Dim validar As Boolean
Dim fechaNac As Date

With Worksheets("sheet1")
    For f = 2 To Cells(.Rows.Count, "L").End(xlUp).Row
        ' Be sure to qualify ALL references.
        curp = .Cells(f, "L").Value2
        fname = .Cells(f, "F").Value2
        lname1 = .Cells(f, "I").Value2
        lname2 = .Cells(f, "J").Value
        gender = .Cells(f, "k").Value2
        fechaNac = .Cells(f, "P").Value2
' works           validar = CheckFirstLetter(lname1, curp, 1, f)
' works           validar = CheckFirstVowel(lname1, curp, 2, f)
             validar = CheckFirstLetter(lname2, curp, 3, f)
'            validar = CheckFirstLetter(fname, curp, 4)
'            validar = CheckDate(fechaNac, curp, 5)
'            validar = CheckGender(gender, curp, 11)
'            validar = CheckConsonant(lname1, curp, 12, 2)
'            validar = CheckConsonant(lname2, curp, 13, 2)
'            pos = posVowel(fname)
'            validar = CheckConsonant(fname, curp, 14, pos)
            If (validar = True) Then
                .Cells(f, "N") = "Valido"
            Else
                .Cells(f, "N") = "No Valido"
            End If
        Next
    End With
End Sub

Function CheckFirstLetter(mystring As String, text As String, indexCurp As Long, index As Long) As Boolean
            Dim i As Long

            Dim ary As Variant
            ary = Split(mystring, " ")

            Dim vocal As String
            vocal = LCase(ary(LBound(ary)))   'Breaks in this line

            Dim vocal2 As String
            vocal2 = LCase(ary(UBound(ary)))

            If (vocal = "de" Or vocal = "del") Then
                vocal = vocal2
            End If

            Dim outStr As String
            outStr = LCase(Mid(text, indexCurp, 1))

            Dim asciinum As String
            asciinum = LCase(Mid(vocal, 1, 1))

            ' Qualify these cell references
            Cells(index, "M") = vocal
            Cells(index, "O") = vocal2

            ' I dont know if the parentheses are needed here, I just like them
            CheckFirstLetter = (asciinum = outStr)

'            If (asciinum = outStr) Then
'                CheckFirstLetter = True
'            Else
'                CheckFirstLetter = False
'            End If
End Function

最后，不要试图对您的if块保持可爱：

If True = True Then: Debug.Print True
Else: Debug.Print False
End If

节省了两行，这使阅读和调试代码更加困难。 您还可以将比较的布尔结果直接分配给布尔变量。 这两个工作：

Result = True = False
Result = (True = False)