更改密码获取请求不更改密码

Question

我有一个MEAN应用程序，它正在尝试为'/ changepassword'实现GET请求。 该文件位于“ / users / changepassword”中。 我使用Mongoose和bcryptjs进行密码哈希处理。 请在下面查看我的代码。

这是/ users / changepassword

// Change Password
router.post('/changepassword', function(req, res){
  var username = req.body.username;
  var password = req.body.oldPassword;
  var newPassword = req.body.newPassword;

  User.getUserByUserName(username, function(err, user){
    if(err) throw err;
    if(user === null){
      res.json({success: false, msg: "The given username does not exist."});
    }else{
      User.comparePassword(password, user.password, function(err, isMatch){
        if(err) throw err;
        if(isMatch)
        {
          User.changePassword(user, newPassword,function(err, changedPassword){
            if(err) throw err;
            else{
              if(changedPassword === true){
                res.json({success: true, msg: "Your password has been changed."});
              }
              else {
                res.json({success: false, msg: "Your password was unable to be changed."});
              }
            }
          });
        }
      });
    }
  });
});

这是/ models / user中的Mongoose changepassword函数

module.exports.changePassword = function(user, newPassword, callback){
  var query = {username: user.username};
  bcrypt.genSalt(10, function(err, salt){
    bcrypt.hash(user.password, salt, function(err, hash){
    if (err) throw err;
    else{
      user.password = hash;
      User.findOneAndUpdate(query, { $set: { password: user.password }}, {new: true}, function(err, newUser){
        if(err) throw err;
        else{
        bcrypt.compare(newPassword, newUser.password, function(err, isMatch){
            if(err) throw err;
            console.log(isMatch);
            callback(null, isMatch);
          });
        }
      });
    }
  });
});
};

这是/ models / user中使用的所有其他功能

module.exports.getUserByUserName = function(username, callback){
  var query = {username: username};
  User.findOne(query, callback);
};

module.exports.comparePassword = function(candidatePassword, hash, callback){
  bcrypt.compare(candidatePassword, hash, function(err, isMatch){
    if(err) throw err;
    callback(null, isMatch);
  });
};

当我使用邮递员时，这是我收到的输出

{
  "success": false,
  "msg": "Your password was unable to be changed."
}

任何帮助深表感谢！ :)

Answer 1

找出问题所在！

module.exports.changePassword = function(user, newPassword, callback){
  var query = {username: user.username};
  bcrypt.genSalt(10, function(err, salt){

// it has to be newPassword instead of user.password
    bcrypt.hash(user.password, salt, function(err, hash){

    if (err) throw err;
    else{
      user.password = hash;
      User.findOneAndUpdate(query, { $set: { password: user.password }}, {new: true}, function(err, newUser){
        if(err) throw err;
        else{
        bcrypt.compare(newPassword, newUser.password, function(err, isMatch){
            if(err) throw err;
            console.log(isMatch);
            callback(null, isMatch);
          });
        }
      });
    }
  });
});
};

// CORRECT ONE
module.exports.changePassword = function(user, newPassword, callback){
  var query = {username: user.username};
  bcrypt.genSalt(10, function(err, salt){
    bcrypt.hash(newPassword, salt, function(err, hash){
    if (err) throw err;
    else{
      user.password = hash;
      User.findOneAndUpdate(query, { $set: { password: user.password }}, {new: true}, function(err, newUser){
        if(err) throw err;
        else{
        bcrypt.compare(newPassword, newUser.password, function(err, isMatch){
            if(err) throw err;
            console.log(isMatch);
            callback(null, isMatch);
          });
        }
      });
    }
  });
});
};