JUnit / Mockito验证`any（HttpPut.class）`时也通过了其他实例

Question

我有一个服务类，该服务类调用REST API来获取，创建，更新和删除订户。 Uri保持不变，但是HTTP方法发生了预期的变化。 我想测试给出的正确方法。 以下是updateSubscriber及其测试的示例。

public class MyService {

    HttpClient httpClient;

    public MyService(HttpClient httpClient) {
        this.httpClient = httpClient;
    }

    //...

    public int updateSubscriber(Subscriber subscriber) throws ... {

        // PUT is the correct method for this request 
        HttpResponse response = httpClient.execute( new HttpPut( "https://example.org/api/subscribers" ) );

        //...
    }

    //...

这是我对JUnit和Mockito的测试：

@RunWith(MockitoJUnitRunner.class)
public class MyServiceTest 
{

    @Mock
    private HttpClient mockHttpClient;

    @Mock 
    private HttpResponse mockResponse;

    @Mock 
    private StatusLine mockStatusline;

    @Mock 
    private HttpEntity mockEntity;

    // test subject
    private MyService myService;

    @Before
    public void setup() {

        // // this will just ensure http* objects are returning our mocked instances so we can manipulate them..
        // when(mockHttpClient.execute(any(HttpGet.class))).thenReturn(mockResponse);
        // when(mockHttpClient.execute(any(HttpPost.class))).thenReturn(mockResponse);
        // when(mockHttpClient.execute(any(HttpPut.class))).thenReturn(mockResponse);
        // when(mockHttpClient.execute(any(HttpDelete.class))).thenReturn(mockResponse);

        // when(mockResponse.getStatusLine()).thenReturn(mockStatusline);
        // when(mockStatusline.getStatusCode()).thenReturn(HttpStatus.SC_OK);

        myService = new MyService(mockHttpClient);
    }

    @Test
    public void testUpdateSubscriber() throws ...
    {   

        when(mockHttpClient.execute(any(HttpPut.class))).thenReturn(mockResponse);

        when(mockResponse.getStatusLine()).thenReturn(mockStatusline);
        when(mockStatusline.getStatusCode()).thenReturn(HttpStatus.SC_OK);

        String responseString = "...";

        // this is consumed by a static method which we cannot mock, so we must deal with an actual entity instance 
        BasicHttpEntity entity = new BasicHttpEntity();
        entity.setContent(new ByteArrayInputStream(responseString.getBytes()));
        when(mockResponse.getEntity()).thenReturn(entity);  

        // create a test case Subscriber instance 
        Subscriber subscriber = new Subscriber();

        int statusCode = myService.updateSubscriber(subscriber);

        assertEquals(HttpStatus.SC_OK, statusCode);

        // just confirm that an HTTP request was made 
        // TODO this isn't working, still passes when wrong Http* method used 
        verify(mockHttpClient, times(1)).execute(any(HttpPut.class));
    }

    //...

但是，当我（错误地）拥有另一个Http *方法实例时，它仍然通过：

// this is wrong, and should fail, but passed :(
HttpResponse response = httpClient.execute( new HttpGet( "https://example.org/api/subscribers" ) ); 

我真的很想能够对此进行测试，因为如果方法错误，执行的操作可能是错误的。 此测试是为了确保PUT方法已正确用于updateSubscriber的HTTP请求。 有任何想法吗？

Answer 1

测试通过，因为HtppPut和HttpGet都是HttpRequestBase实现类，将HttpPut从HttpRequestBase类更改为HttpPut类

 when(mockHttpClient.execute(any(HttpPut.class))).thenReturn(mockResponse);

所以现在，如果您尝试使用GET调用，则测试将失败，并出现NullPointerException因为GET调用没有存根

Answer 2

不知道这是否是我问题的正确答案，但是我设法使用自定义参数匹配器使测试按预期工作：

package uk.ac.strath.matchers;

import org.apache.http.client.methods.HttpUriRequest;
import org.mockito.ArgumentMatcher;

public class HttpMethodMatcher implements ArgumentMatcher<HttpUriRequest> {

    private String expectedClassName;

    // constructors
    public HttpMethodMatcher(String expectedClassName) {
        this.expectedClassName = expectedClassName;
    }

    @Override
    public boolean matches(HttpUriRequest httpMessage) {
        if (httpMessage.getClass().getName().equals(expectedClassName)) {
            return true;
        }

        return false;
    }
}

现在在测试中，我可以执行以下操作：

verify(mockHttpClient, times(1)).execute( argThat(new HttpMethodMatcher( HttpGet.class.getName() )) );

本教程很有帮助： https : //www.baeldung.com/mockito-argument-matchers