繁体 English 中英

请求审查代码 [ HttpURLConnection ] [关闭]

[英]Requesting a review for the code [ HttpURLConnection ] [closed]

原文 2019-11-15 16:03:20 1 0 java/ httpurlconnection

我有下面的代码，我通过 POST 发送一些内容，然后使用响应。 我想知道是否可以进行任何优化以及是否存在连接泄漏的可能性。

 String out;
 HttpURLConnection connection = null;
        try {
            URL url = new URL(requestUrl);
            connection = (HttpURLConnection) url.openConnection();
            connection.setConnectTimeout(retryWaitTime);
            connection.setReadTimeout(socketTimeOut);
            connection.setDoInput(true);
            connection.setDoOutput(true);
            connection.setRequestMethod("POST");
            connection.setRequestProperty("Accept", "application/xml");
            connection.setRequestProperty("Content-Type", "application/xml; charset=UTF-8");
            OutputStreamWriter writer = new OutputStreamWriter(connection.getOutputStream(), StandardCharsets.UTF_8);
            writer.write(xml);
            writer.close();

            int statusCode = connection.getResponseCode();
            if (statusCode == HttpURLConnection.HTTP_OK) {
                BufferedReader br = new BufferedReader(new InputStreamReader(connection.getInputStream()));

                String line;
                while ((line = br.readLine()) != null) {
                    xmlString.append(line);
                }

                br.close();  
                out= xmlString;

            } else {
                out=xml;

            }
            if (connection.getInputStream() != null)
                connection.getInputStream().close();

        }
        catch (Exception e) {
          assert connection != null;
            if (connection.getErrorStream() != null)
                connection.getErrorStream().close();
        }