我无法在潮人中修复 lock_pairs function

Question

我正在尝试创建一个递归 function 来检查周期。 我在循环 function 中使用了一个 for 循环来检查我们要锁定的对中的输家是否是另一个锁定对中的赢家，如果它是真的，我们将拿那对并查看该对中较松的它是否不是赢家在另一对中，直到我们发现较松的人是主要对的赢家，并且是否会产生循环。

#include <cs50.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

// Max number of candidates
#define MAX 9

// preferences[i][j] is number of voters who prefer i over j
int preferences[MAX][MAX];

// locked[i][j] means i is locked in over j
bool locked[MAX][MAX];

// Each pair has a winner, loser
typedef struct
{
    int winner;
    int loser;
}
pair;

// Array of candidates
string candidates[MAX];
pair pairs[MAX * (MAX - 1) / 2];

int pair_count;
int candidate_count;

// Function prototypes
bool vote(int rank, string name, int ranks[]);
void record_preferences(int ranks[]);
void add_pairs(void);
void sort_pairs(void);
void lock_pairs(void);
void print_winner(void);

int main(int argc, string argv[])
{
    // Check for invalid usage
    if (argc < 2)
    {
        printf("Usage: tideman [candidate ...]\n");
        return 1;
    }

    // Populate array of candidates
    candidate_count = argc - 1;
    if (candidate_count > MAX)
    {
        printf("Maximum number of candidates is %i\n", MAX);
        return 2;
    }
    for (int i = 0; i < candidate_count; i++)
    {
        candidates[i] = argv[i + 1];
    }

    // Clear graph of locked in pairs
    for (int i = 0; i < candidate_count; i++)
    {
        for (int j = 0; j < candidate_count; j++)
        {
            locked[i][j] = false;
        }
    }

    pair_count = 0;
    int voter_count = get_int("Number of voters: ");

    // Query for votes
    for (int i = 0; i < voter_count; i++)
    {
        // ranks[i] is voter's ith preference
        int ranks[candidate_count];

        // Query for each rank
        for (int j = 0; j < candidate_count; j++)
        {
            string name = get_string("Rank %i: ", j + 1);

            if (!vote(j, name, ranks))
            {
                printf("Invalid vote.\n");
                return 3;
            }
        }

        record_preferences(ranks);

        printf("\n");
    }

    add_pairs();
    sort_pairs();
    lock_pairs();
    print_winner();
    return 0;
}

// Update ranks given a new vote
bool vote(int rank, string name, int ranks[])
{
    // TODO
    for(int i = 0; i < candidate_count; i++)
    {
        if(!strcmp(candidates[i], name))
        {
            ranks[rank] = i;
            return true;
        }
    }
    return false;
}

// Update preferences given one voter's ranks
void record_preferences(int ranks[])
{
    // TODO
    int x, y, i, j;

    for (i = 0; i < candidate_count; i++)
    {
        for (j = 0; j < candidate_count; j++)
        {
            x = ranks[i];
            y = ranks[j];

            if ( i < j)
            {
                preferences[x][y]++;
            }

        }
    }
    return;
}

// Record pairs of candidates where one is preferred over the other
void add_pairs(void)
{
    // TODO
    int n = 0;
    int m = 0;
    while (n < MAX *(MAX - 1)/2)
    {
        for (int i = 0; i < candidate_count; i++)
        {
            for (int j = 0; j < candidate_count; j++)
            {
                if ((preferences[i][j]) > (preferences[j][i]))
                {
                    pairs[n].winner = i;
                    pairs[n].loser = j;
                    n++;
                    pair_count++;
                }
                else if ((preferences[i][j]) == (preferences[j][i]) && i != j)
                {
                    pair_count++;
                }
            }
        }
    }
    return;
}

// Sort pairs in decreasing order by strength of victory
void sort_pairs(void)
{
    // TODO
    int n, m;
    for (int i = 0; i < pair_count - 1; i++)
    {
        for (int j = i + 1; j < pair_count; j++)
        {
            if ((pairs[i].winner - pairs[i].loser) > (pairs[j].winner - pairs[j].loser))
            {
                n = pairs[i].winner;
                m = pairs[i].loser;
                pairs[i].winner = pairs[j].winner;
                pairs[i].loser = pairs[j].loser;
                pairs[j].winner = n;
                pairs[j].loser = m;

            }
        }
    }
    return;
}

bool cycle(int x, int y );
// Lock pairs into the candidate graph in order, without creating cycles
void lock_pairs(void)
{
    // TODO
    locked[pairs[0].winner][pairs[0].loser] = true;
    
    for (int n = 1; n < pair_count; n++)

        if(!cycle(pairs[n].winner, pairs[n].loser))
        {
            locked[pairs[n].winner][pairs[n].loser] = true;
        }
    return;
}

bool cycle(int x, int y )
{

    //checking if a loser in other locked pairs is a winner in pair w're looking to lock or not
    
    if (pairs[j].loser == x)
    {
        return true;
    }
    
    for (int j = 0; j < pair_count; j++)
    {
        if (locked[x][y] == true)
        {

            if(y == pairs[j].winner)
            {
                int h = j;
                cycle(h, j);
                
            }
        }

    }

    return false;
}

// Print the Swinner of the election
void print_winner(void)
{
    // TODO
    for (int i = 0; i < pair_count; i++)
    {
        for (int j = 0; j < pair_count; j++)
        {
            if ((locked[i][j] = true) && ( i != pairs[j].loser))
            {
                printf("%s\n", candidates[i]);
            }

            else if  ((preferences[i][j]) == (preferences[j][i]) && i != j)
            {
                 printf("%s\n", candidates[i]);
                 printf("%s\n", candidates[j]);
            }
        }
    }
    return;
}