T-SQL：存储过程的执行

Question

我有一个程序应该将数据保存到临时表中，最后删除旧记录并将新记录插入到真实表中。

程序结束如下：

...
--THIS SELECT HAS THE CORRECT DATA
SELECT * FROM @NewTempTable;

BEGIN TRY
    BEGIN TRANSACTION;

    --DELETE OLD COMPONENTS
    DELETE FROM AlteracaoEngenharia.hComponents 
    WHERE Id IN (SELECT C.Id  
                 FROM AlteracaoEngenharia.hComponents AS C
                 JOIN AlteracaoEngenharia.hEngineeringChanges AS EC ON C.EngineeringChangeId = EC.Id
                 WHERE C.Name NOT LIKE '%(Manual)%' AND EC.State LIKE 'Aberto');

    INSERT INTO AlteracaoEngenharia.hComponents (Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId)
        (SELECT 
             Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId 
         FROM 
             @NewTempTable);

    COMMIT TRANSACTION;
END TRY
BEGIN CATCH
END CATCH
END

如果我 select 的所有过程，直到begin try和 f5（执行它）它没有给出任何错误，我在@NewTempTable上得到预期的数据； 但是当保存程序并尝试执行它时，我收到以下错误

虽然@NewTempTable有预期的数据，但过程的执行返回 -6 并且数据没有插入到AlteracaoEngenharia.hComponents中。

我收到的数据都不是 null， AlteracaoEngenharia.hComponents列也不是不可为空的。

我在 TestServer 中也有完全相同的程序（某些连接是不同的，但如果那是错误，我将没有数据）并且该程序运行良好。

我知道我没有展示大部分程序，但它有点复杂并且包含合理的信息。 我希望我能根据我所描述的内容获得一些关于正确方向的指示。

PS：我已经尝试过@newTempTable和##newTempTable

Answer 1

试试下面的代码块：

BEGIN TRANSACTION;
BEGIN TRY
 --DELETE OLD COMPONENTS
    Delete From AlteracaoEngenharia.hComponents where Id in
        (Select C.Id From AlteracaoEngenharia.hComponents as C
            Join AlteracaoEngenharia.hEngineeringChanges as EC on C.EngineeringChangeId = EC.Id
            Where C.Name not like '%(Manual)%' and EC.State like 'Aberto');

    Insert Into AlteracaoEngenharia.hComponents (Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId)
        (Select Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId From @NewTempTable);

END TRY
BEGIN CATCH 
IF @@TRANCOUNT > 0
    BEGIN   
    ROLLBACK TRANSACTION;
    throw;
    END 
END CATCH;
IF @@TRANCOUNT > 0
    BEGIN   
    COMMIT TRANSACTION;
    PRINT 'Successfully Completed'
    END

Answer 2

确保发生错误后完全ROLLBACK的最佳方法是使用XACT_ABORT ，这会强制所有错误中止批处理并回滚事务：

SET XACT_ABORT ON;
SET NOCOUNT ON;

BEGIN TRANSACTION;

    --DELETE OLD COMPONENTS
    DELETE FROM AlteracaoEngenharia.hComponents 
    WHERE Id IN (SELECT C.Id  
                 FROM AlteracaoEngenharia.hComponents AS C
                 JOIN AlteracaoEngenharia.hEngineeringChanges AS EC ON C.EngineeringChangeId = EC.Id
                 WHERE C.Name NOT LIKE '%(Manual)%' AND EC.State LIKE 'Aberto');

    INSERT INTO AlteracaoEngenharia.hComponents (Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId)
        (SELECT 
             Name, OldQuantity, Quantity, CDP, Value, Type, EngineeringChangeId 
         FROM 
             @NewTempTable);

COMMIT TRANSACTION;

这里不需要TRY/CATCH或ROLLBACK ，任何错误都会自动回滚。