Junit void方法测试

Question

我正在测试一种返回类型为 void 且带有一个参数的方法。 我试图至少获得一些代码覆盖率。 这是我正在测试的一种方法：

@Service
public class VaultService {

    private final ProductRepository repository;

    private final DatabaseService databaseService;

    public VaultService(
            @Autowired BuildProperties buildProperties,
            ProductRepository repository,
            DatabaseService databaseService
    ) {
        logger.info("Creating service");

        this.repository = repository;
        this.databaseService = databaseService;
    }

    protected void checkVaultResponseErrors(VaultResponse vaultResponse) {
        if (vaultResponse.responseStatus != ResponseStatus.SUCCESS) {
            vaultResponse.errors.forEach(error -> {
                if (vaultResponse.responseStatus.equals(ResponseStatus.EXCEPTION)) {
                    throw new VaultException(error.getMessage());
                }
                if (vaultResponse.responseStatus.equals(ResponseStatus.FAILURE)) {
                    throw new VaultFailure(error.getMessage());
                }
            });
        }
    }

VaultResponse class 看起来像这样

@Getter
@Setter
@JsonInclude(JsonInclude.Include.NON_NULL)
public class VaultResponse {
    @JsonProperty("responseStatus")
    public ResponseStatus responseStatus;

    @JsonProperty("errors")
    public List<Error> errors;
}

这是我的测试。 我收到Mockito.verify错误，但代码的 rest 也没有得到任何覆盖。 我显然做错了什么。

@Test
void should_check_vaultResponse_for_errors() {
    VaultService spyService = Mockito.spy(vaultService);
    VaultResponse vaultResponse = new VaultResponse();
    ResponseStatus status = ResponseStatus.SUCCESS;
    List<Error> error = new ArrayList<>();

    vaultResponse.setResponseStatus(status);
    vaultResponse.setErrors(error);

    doThrow(IllegalArgumentException.class)
            .when(spyService).checkVaultResponseErrors(vaultResponse);
    doNothing().when(spyService).checkVaultResponseErrors(vaultResponse);

    verify(spyService, times(1)).checkVaultResponseErrors(vaultResponse);
}

Answer 1

您的测试方法清楚地表明您要测试checkVaultResponseErrors方法。 这意味着你绝对不应该嘲笑它。 您可以模拟使其工作所需的任何东西，但不能模拟方法本身。

在我看来，要编写三个测试：

1. 没有错误：

// create VaultResponse without errors; you have that now

assertDoesNotThrow(() -> vaultService.checkVaultResponseErrors(vaultResponse));

2. 有一个例外：

// create VaultResponse with status EXCEPTION

VaultException thrown = assertThrows(VaultException.class,
        () -> vaultService.checkVaultResponseErrors(vaultResponse));
// you can now assert that thrown is what you expect

3. 失败了：

// create VaultResponse with status FAILURE

VaultFailure thrown = assertThrows(VaultFailure.class,
        () -> vaultService.checkVaultResponseErrors(vaultResponse));
// you can now assert that thrown is what you expect