为什么该对象数组中的每个元素都被最后一个对象覆盖？

Question

I have the following code:

public static void main(String[] args) {
  Player players[] = new Player[2];
  Scanner kb = new Scanner(System.in);
  System.out.println("Enter Player 1's name");
  players[0] = new Player(kb.nextLine());
  System.out.println("Enter Player 2's name");
  players[1] = new Player(kb.nextLine());
  System.out.println("Welcome "+ players[0].getName() + " and " + players[1].getName());    
}

It is meant to create a new player object and store the name of the player, while keeping all the objects in the array.

Here is the player class:

public class Player {
  static String name;
  public Player(String playerName) {
    name = playerName;
  }

  public String getName(){
    return name;
  } 
}

What actually happens is that it works when I just have 1 object, but when I have 2, each element in the array is the same as the second. When I have 3 objects in the array, each element is the same as the 3rd, etc.

I'm not sure why this is happening, or how to correct it, and it's been baffling me for hours :/

Answer 1

Its because of the static field. Statics are used across object instances. They are stored at class level.

Below code would work:

class Player
{
    String name;

    public Player(String playerName)
    {
        name = playerName;
    }

    public String getName()
    {
        return name;
    }
}

Answer 2

将静态字符串名称更改为私有字符串名称

Answer 3

Name field should not be static. Static means that the variable is actually global and shared across all class instances.

Answer 4

With the keyword static you have made name a class variable which is NOT an instance variable. A class variable is common to all the objects. Click for some more reading .