需要函数来查找数组中的最大值，将其返回到main（）并打印出来

Question

To me, my program looks like it should do what I want it to do: prompt a user to enter 10 values for an array, then find the largest of those values in the array using a function, then return the largest number to the main () function and print it out.

But, when I enter values, I never get numbers back that look anything like the ones I'm entering.

For example, let's say I enter just "10, 11" I get back "1606416648 = largest value".

Does anyone know what I'm doing wrong?

Here's the code:

#include <stdio.h>
#define LIMIT 10
int largest(int pointer[]); 
int main(void)
{

int str[LIMIT];
int max;
int i = 0;

printf("Please enter 10 integer values:\n");
while (i < LIMIT)
{
    scanf("%d", &str[i]);
    i++;
}
// Thanks for your help, I've been able to make the program work with the above edit!
max = largest(str);
printf("%d = largest value\n", max);

return 0;
}

int largest(int pointer[])

{
int i;
int max = pointer[0];

for (i = 1; i < LIMIT; i++)
{
   if (max < pointer[i])
        max = pointer[i];
}
return max;
}

Answer 1

scanf("%d", &str[LIMIT]); reads in one number and puts it in the memory location one past the end of your array.

After changes:

1. You don't need scanf() in your while condition; it should go in the while body instead.

2. Your scanf() still isn't quite right. You need to tell it where in the array you want to store the input.

3. str[i]; doesn't do anything.

Answer 2

printf("Please enter 10 integer values:\\n"); scanf("%d", &str[LIMIT]);

This doesn't do what you think. First, it only reads one number in. Second, you are reading it into the last position + 1 of the array.