为什么我的代码没有填写？

Question

Dim SLR As Range
Dim ELR As Range

Private Sub Worksheet_Change(ByVal Target As Range)
If Target.Cells.Count > 1 Then Exit Sub
On Error Resume Next


Select Case UCase(Target.Value)

Case "START-LOCATION"
    Target.Offset(0, 0).Select
    Selection.ClearContents
    SLR = ActiveCell.Address
    Target.Offset(-1, 1).Select



Case "END-LOCATION"
    Target.Offset(0, 0).Select
    Selection.ClearContents
    ELR = ActiveCell.Address
    Target.Offset(0, -1).Select
    ActiveSheet.Range(SLR, ELR).FillDown

End Select
End Sub

Hello all, I have the above code, it is supposed to set the variable on start location for the first cell, and on end location it sets the second variable and then fills down the cells from SLR to ELR, however it isn't working and isn't providing me with an error message, any ideas?

Answer 1

Try to change the followings:

SLR= Activecell.Address 

into

Set SLR = Activecell

and do the same for ELR:

Set ELR = Activecell

Answer 2

On Error Resume Next is always a bad idea. If I was king of the world I would make this command illegal, the error handler should be for when something unexpected happens that crashes your code.

The most import thing with your macro is that the data the user gets at the end of it is correct. If that means that when the code crashes and the user call you over then that's what it takes. But having On Error Resume Next means that no one will ever know if your code has crashed and no one will ever know that the data is wrong.

Never ever use On Error Resume Next!!!!!

As for this bit of code you'll learn more about your problem if you remove On Error Resume Next.