更新while循环中的所有行

Question

I'm trying to wrap my brain around what I'm doing wrong here. This is the function that is called when I want to delete a record. The record is deleted, but I want the display_order to reestablish itself, if the record that is delete is somewhere in the middle of the rows. So that the first record will always be 1, the second always 2, etc.

<?php
    $counter = 1;
    require ("connection.php");
    $sql = "SELECT * FROM pages";
    $result = $conn->query($sql) or die(mysqli_error());

    $id = $_GET['id'];
    $delete = mysqli_query($conn, "DELETE FROM pages WHERE id ='".$id."'");
    if ($delete){

        while($row = $result->fetch_object()){
            $reord = "UPDATE pages SET display_order = '".$counter."'";
            $result2 = $conn->query($reord) or die(mysqli_error());
            $counter++;
        }

        header("Location: admin.php");
    }else{
        echo "NOTHING DELETED id=".$id;
    }
?>

The error that I'm receiving is that all the records "display_order" are now updated to the maximum number of records, say for instance, I had four records, I deleted one of them, now all remaining records have a display_order of 3.

Answer 1

You missed to add the page id as a WHERE condition to the query. Like this:

while($row = $result->fetch_object()){
    $reord = "UPDATE pages SET display_order = '".$counter."' WHERE page_id = '" . $row->page_id . "'";
    $result2 = $conn->query($reord) or die(mysqli_error());
    $counter++;
}

Note: If missing the WHERE clause all records in the pages table will be updated.