如何使此电子邮件确认有效？

Question

I've tried sending simple email using the mail function and it works. But when I try to insert that to my program it won't. Can someone tell me which part is wrong because I am pretty sure that it is not about xampp/sendmail config - I already tried 2 simple mailing programs and they all work except this one.

I tried my best to put(...) in place of unnecessary lines. I think the problem is that, it can't go to the part where the prog reads the email function part?

Here's my register.php:

<?
session_start();
if(isset($_POST['register']))
{
    include('/class.register.php');

    $register = new Register();
if($register->process()) {
    header('location: login.php');
}
else  {
    $register->show_errors();
}
}


?>

<form method= "POST" action="<?=$_SERVER['PHP_SELF'];?>">
<table>
<tr><td>Username:</td><td><input type="text" name="ruser" required="required" /></td></tr>
<tr><td>Email:</td><td><input type="text" name="remail" required="required" /></td></tr>
<tr><td>Password:</td><td><input type="password" name="rpass" required="required" /></td></tr>
<tr><td>Title:</td><td><input type="text" name="rtitle" required="required" /></td></tr>
<tr><td>First Name:</td><td><input type="text" name="rfname" required="required" /></td></tr>
<tr><td>Last Name:</td><td><input type="text" name="rlname" required="required" /></td></tr>
<tr><td>Mobile Number:</td><td><input type="text" name="rmobile" required="required" /></td></tr>


</table>

<input type="submit" name="register" value="Sign Up" />

</form>

Here's my class.register.php:

<?

class Register
{

...

private $errors;  

public function __construct()
{
    $this->errors = array();

    ...;

    $this->token = $_POST['token'];
    $this->passmd5 = md5($this->password);

}

public function process()
  {
  if($this->valid_data() && $this->send_email())
$this->register();

return count($this->errors)? 0: 1;

}

public function filter($var)
{
    return preg_replace('/[^a-zA-z0-9@.]/','',$var);
}
public function user_exists()
{
    ...
} 

public function email_exists()
 ...

public function register()
{
    ...

}

public function show_errors()
 echo "<h3>Errors</h3>";

    foreach($this->errors as $key=>$value)
    echo $value."<br>";

public function valid_data()
...


public function send_email()
{

$from = 'jeremiah@citydelivery.ph';
$to = $_POST['remail'];
$subject = 'Registration confirmation';
$message = 'Please click the following link or copy and paste it
into your browser to complete the registration process: ';
$message .= 'http://example.com/confirm.php?u=';
$message .= urlencode($_POST['ruser']);
$message .= '&amp;t=';
$message .= urlencode($_POST['token']);

return mail($to, $subject, $message, $from);

}


}
?>

Answer 1

$this->send_email must be $this->send_email()

It is a function not a variable ;)

Also you use it in a statement, but send_mail() doesn't return anything, so it returns null, which ends up as false.

So do return mail($to, $subject, $message, $from); to fix that

An if statement is execute in the order until it hits a false, when only using && (and)

You have

if($this->valid_token() && $this->valid_data() && $this->send_email())

So it is possible it never hits send_mail() because valid_data() is for example false.

To check this use var_dump($this->valid_token(), $this->valid_data(), $this->send_email() The first one that hits false is your problem to fix, and so one.

Use the following process function, it checks which on is the problem. I recommend after it works to remove the die() functions

public function process()
  {
if($this->valid_token()) { die('token is the problem'); }
if($this->valid_data()) { die('valid data is the problem'); }
if($this->send_email()) { die('send email is the problem'); }

 if($this->valid_token() && $this->valid_data() && $this->send_email)
    $this->register();

return count($this->errors)? 0: 1;

}

Answer 2

I would like to thank all of you guys who contributed. I fixed the problem by creating another file which is sendmail.php and then have it included in my register.php.