后控制器挂钩中的CodeIgniter重定向循环

Question

Here is my Controller:

<?php
  class Check_Login {
    var $CI;
    var $class;
    var $allowed_klasses = array('user', 'testing', 'home', 'lesson_assets', 's3_handler', 'ajax', 'api', 'pages', 'invite', 'mail', 'partner', 'renew', 'store', 'news', 'breathe','popup','subscription', 'lessons');

    public function __construct() {
      $this->CI =& get_instance();

      if(!isset($this->CI->session)) {
        $this->CI->load->library('session');
      }

      if(!nash_logged_in()) {
        $this->CI->session->sess_destroy();
        redirect('/');
      }

      $this->_set_accessed_klass();
    }

    public function auth_check() {
      if($this->CI->session->userdata('id')) {
        $query = $CI->db->query("SELECT authentication_token FROM users WHERE id = ".$this->CI->session->userdata('id')." AND authentication_token IS NOT NULL");
        if(!in_array($this->class, $this->allowed_klasses)) {
          if($query->num_rows() == 0){
            redirect('/user/logout');
          }
        }else{
          return;
        }
      }else{
        return;
      }
    }

    private function _set_accessed_klass() {
      $this->class = $this->CI->router->fetch_class();
    }
  }

The lines that I am referring too are:

if(!nash_logged_in()) {
        $this->CI->session->sess_destroy();
        redirect('/');
      }

Essentially, the app uses the nash_logged_in() method to check against our OAuth system to see if the user is truly "logged in". When this happens a redirect loop happens.

The nash_logged_in method simply returns a JSON key of either TRUE or FALSE. Any reason why I would be running into this redirect loop?

nash_logged_in method:

if(!function_exists('nash_logged_in')) {
  function nash_logged_in(){
    $url = NASH_OAUTH_URL . '/api/v1/loggedin.json';
    $json = file_get_contents($url);
    $data = json_decode($json);
    return $data->loggedin;
  }
}

Answer 1

If nash_logged_in() does not return a boolean false or integer 0 or null, then the statement is evaluated as true therefore your redirect.

Post nash_logged_in() here to see what's going on there.

Answer 2

You wont need to use hooks for this method

post controller hook

You could just extend CI_Controller and run the Authentication library in the __constructor of the child classes that need to be authenticated.

You current controller is a little messy and it looks like a library to me, not a controller, you don't need to re-instantiate the super object if your doing it all in your controller!

However, my suggestion is to move everything to a library(as there are a number of controllers/classes that depend on it).

Some elements of your code don't make sense to me, possibly because I can't see the bigger picture from the code you have posted.

This might give you some food for though(or not) regardless this is how I would approach it.

application/libraries/authentication.php

class Authentication
{

    protected $allowedClasses = array ( ) ;
    protected $userId         = null ;
    protected $nashURL ;

    const NASH_OAUTH_URL = '' ;

    public function __construct ()
    {
        $this->nashURL = static::NASH_OAUTH_URL . '/api/v1/loggedin.json' ;

        //check for a user id in session
        //this may not be set yet!!
        $this->userId = (isset ( $this->session->userdata ( 'id' ) ))
            ? $this->session->userdata ( 'id' )
            : null ;

        /** Load dependancies * */
        $this->load->model ( 'Authentication_Model' ) ;
        $this->load->library ( 'Session' ) ;

    }

    /**
     * nashCheckLoginViaCurl
     * @return boolean
     */
    protected function nashCheckLoginViaCurl ()
    {
        if ( function_exists ( 'curl_init' ) )
        {
            return show_error ( "Enabled CURL please!" , 500 ) ;
        }

        $curl = curl_init () ;
        curl_setopt_array ( $curl ,
                            array (
            CURLOPT_URL => $this->nashURL ,
            /** CHECK CURL DOCS FOR FULL LIST OF OPTIONS - FILL THE REST YOURSELF * */
        ) ) ;

        if ( curl_errno ( $curl ) )
        {
            return false ;
        }

        $info     = curl_getinfo ( $curl ) ;
        $responce = curl_exec ( $curl ) ;
        curl_close ( $curl ) ;

        //Check and make sure responce is a BOOLEAN and not a STRING
        //we will typecast below just incase
        $responce = json_decode ( $responce ) ;

        return ($info[ 'http_code' ] == '200' and ( bool ) $responce->loggedin === true)
            ? true
            : false ;

    }

    /**
     * verifyAccess
     * @param CI_Controller $class (Dependancy Injection)
     * @return Mixed
     *
     */
    public function verifyAccess ( CI_Controller $class )
    {
        //Is there a userId in the session
        //ie: is user logged In
        if ( is_null ( $this->userId ) or ! ( int ) $this->userId )
        {
            return false ;
        }

        //grab list of allowed classes
        $this->allowedClasses = $this->listAllowedClasses () ;

        //check to see if $class is in list of allowed classes
        if ( ! in_array ( $class , $this->allowedClasses ) )
        {
            return false ;
        }
        //check to see if nashCheckLoginViaCurl returned true
        if ( ! $this->nashCheckLoginViaCurl () )
        {
            $this->logout () ;
            return false ;
        }

        //return boolean or $authentication_token based on DB query
        return $this->Authentication_Model->isUserIdRegistered ( $this->userId ) ;

    }

    /**
     * logout
     * @return void
     */
    public function logout ()
    {
        $this->session->unset_userdata ( array ( 'id' => 0 ) ) ;
        $this->session->sess_destroy () ;
        $this->session->sess_start () ;
        return redirect ( '/' ) ;

    }

    /**
     * listAllowedClasses
     * MAYBE USE A CONFIG FILE FOR THIS?
     * @return array
     */
    protected function listAllowedClasses ()
    {
        return array (
            'user' , 'testing' , 'home' , 'lesson_assets' , 's3_handler' , 'ajax' ,
            'api' ,
            'pages' , 'invite' , 'mail' , 'partner' , 'renew' , 'store' , 'news' ,
            'breathe' ,
            'popup' , 'subscription' , 'lessons'
            ) ;

    }

    /**
     * Load CI Super object object
     *
     * @param string $object
     * @return object
     */
    public function __get ( $object )
    {
        return get_instance ()->$object ;

    }

}

application/models/authentication_model.php

class Authentication_Model extends CI_Model
{

    public function isUserIdRegistered ( $uid )
    {
        $this->db->select ( 'authentication_token' )
            ->from ( 'users' )
            ->where ( 'id' , $uid )
            ->where ( 'authentication_token IS NOT' , 'NULL' )
            ->limit ( 1 ) ;

        $query = $this->db->get () ;

        return ( $query->num_rows () > 0 )
            ? $query->result ()
            : FALSE ;

    }

}

application/core/MY_Controller.php

class MY_Controller extends CI_Controller
{

    protected $authentication_token ;

    public function __construct ()
    {
        parent::__construct () ;
        $this->load->library ( 'authentication' ) ;

    }

    protected function _verifyAccess ( $class )
    {
        $authorized = $this->authentication->verifyAccess ( strtolower ( $class ) ) ;

        if ( ! $authorized )
        {
            //kill further script execution by returning
            //redirect url
            return redirect ( 'login' ) ;
        }
        else
        {
            $this->authentication_token = $authorized ;
        }
        return ; //return control back to the controller who called me

    }

}

* Testing Different Controllers - simulate post controller hook *

class Some_Controller extends MY_Controller
{

    public function __construct ()
    {
        parent::__construct () ;

        $this->_verifyAccess ( __CLASS__ ) ;

    }

}

-

class Another_Controller extends MY_Controller
{

    public function __construct ()
    {
        parent::__construct () ;

        $this->_verifyAccess ( __CLASS__ ) ;

    }

}