语法错误：丢失； JavaScript中的before语句

Question

This is the code concerned:

    var membre = '<?= $_SESSION['login'] ?>';

I get this error when I check the Firebug console: SyntaxError: missing ; before statement in Javascript

And the Javascript doesn't execute itself. What's weird is that this used to work, and it also works in local, without an issue.

Do you know why? Or is there another way to get the 'login' SESSION in a Javascript variable?

Thanks

Answer 1

You should not dump PHP variables into JavaScript strings like that. There is a mechanism already in place:

var membre = <?php echo json_encode($_SESSION['login']) ?>;

This will automatically add quotes and escape any problematic characters in a string. It can also be used for numbers and booleans (passed raw), and even arrays (converted to literals).

Answer 2

Your line of code should be either this (1):

// double quotes on the outside and single quotes on the inside or vice versa
var membre = "<?= $_SESSION['login'] ?>";

or this (2):

var membre = '<?= $_SESSION[' + login + '] ?>';

This depends on if you want to access a property with the name "login" (1) or if you want to access a property with the content of a javascript variable named "login" (2).

Anyway, your code ( var membre = '<?= $_SESSION['login'] ?>'; ) is actually two separated string with the name "login" in the middle. So javascript wants to assign the string "<?= $_SESSION[" to the variable membre and expects a semicolon after that. But instead of a semicolon it finds the word "login", which it thinks is a different statement. That is why you get the error "missing ; before statement".

EDIT

As Felix Kling pointed out, I was an the wrong path here, since the PHP code inside <?= ... ?> is evaluated first (see his comment below). So, the inner single quotes are not the issue here.