excel-遍历工作表

Question

I have never used Marcos in Excel before only in Access. What I want to do is loop through the worksheet and where column X and Y are not null extract the information into a new worksheet. But row Y may have more than 1 value and I would like to create a new record for each value in Y with X. each value is separated by a comma.

The result I would Like is

a C3

a C4

b C6

b C7

b C10

And so on

Here is my code so far:

Sub Extract()
'
' Extract Macro
'
Dim WkSht As Worksheet, myOtherSheet As Worksheet, myBook As Workbook
Dim r As Integer
Dim Regex
Dim Match
Dim text
Set myBook = Excel.ActiveWorkbook
Set myOtherSheet = myBook.Sheets("New")
Set Regex = CreateObject("VBScript.RegExp")
Regex.Patten = """[^""]*""|[^,]*"
Regex.Global = True




j = 0
For Each WkSht In ThisWorkbook.Worksheets
    If WkSht.Name = "Sheet1" Then
        For r = 1 To 1000
          If WkSht.Rows(r, B).Value <> "" & WkSht.Rows(r, G).Value <> "" Then
          text = WkSht.Rows(r, G).Value
           For Each Match In Regex.Execute(text)
           myOtherSheet.Cells(j, 1).Value = WkSht.Cells(r, B)
           myOtherSheet.Cells(j, 2).Value = Match
           j = j + 1
           Next Match
           Exit For
           End If
           r = r + 1
           Next r
           Exit For
           End If
           Next WkSht



End Sub

Im unable to get this to run, I think my syntax is wrong for the regex, iv only ever used it in c#, Is this the best option for what I am trying to achieve, any help would be greatly appreciated ?

Answer 1

to fix the 1004 error, change

Rows(r, B).Value

to

Range(r, B).Value

the Rows property only takes a single index, you are trying to test a cell, so muct use either the Range or Cell object.

also to make programming with RegEx easier, add a reference to the Microsoft VBScript Regular Expressions 5.5 library :

on the Tools>References menu in the VB Editor.

Then you can declare Dim Regex as RegExp and use Set Regex = New RegExp

This will give you Intellisense which will help you code corerctly.

For a tutorial in using Regular expressions from Excel vba, see

• MacroStash: Regular Expression Tutorial for Excel VBA
• Regular Expressions Website

Also, the in Tools>Options Editor tab, check all the boxes like Require Variable declaration and Auto List Members