php Notices of Undefined Variable＆试图获取非对象的属性

Question

Am learning & executing php by working on Joomla project How to Improve this code & resolve the PHP Notices - Any suggestions - solutions - well appreciated !!

Notice : Undefined variable: cond in*/home/mygames/public_html/components/com_toys/models/category.php on line 140 (which is $sql line)*

   function loadSubCat($id,$Carmodel,$minprice,$maxprice){
   $mainframe =& JFactory::getApplication();
   $option = JRequest::getCmd('option');
   $database =& JFactory::getDBO();
   global $Itemid;  
   if($Carmodel!="")
   $cond=" and prod_id='$Carmodel' ";
   $sql = "Select * from #__toycar_products Where prod_cat_id='".$id."' $cond and prod_status='1' and prod_id in (select v_prod_id from #__toycar_variants)  Order By prod_sorder";

Notice : Trying to get property of non-object in /home/truecar7/public_html/components/com_toys/models/category.php on line 200

Line 200 is return $row->id;

   function getItemIdByName($Name){
   $mainframe =& JFactory::getApplication();
   $option = JRequest::getCmd('option');
   $database =& JFactory::getDBO();
   $sql = "Select id  from #__menu Where name = '".$Name."'";
   $database->setQuery($sql);
   $row = $database->loadObject();
   return $row->id;
}

Edit

Hello Lodder & Elin, it works but like this, else it's showing undefined variable notice for row on return $row line.

function getItemIdByName($Name){
$db = JFactory::getDBO();
$query = $db->getQuery(true);
$query->select('*')
 ->from('#__menu')      
 ->where('id = ' . $db->quote($Name));      
$db->setQuery($query);
$rows = $db->loadObjectList();

foreach ($rows as $row){
    $row = $row->msg;
     }    
$row='';
return $row;
}

Answer 1

For your Undefined Notice , You have to modify your codes like this

$cond = '';
if($Carmodel!="") {
   $cond = " and prod_id='$Carmodel' ";
}

For Trying to get property of non-object Notice : I think $row is empty that is why throws notice.Check $row

var_dump($row);

Problem :

$database->loadObject(); // This line

Answer 2

Try using the following. I have made some changes to your function and used Joomla 2.5 coding standards for the database query.

$Name = "XXXXXXXXX";  //define the name variable

function getItemIdByName($Name){
    $db = JFactory::getDBO();
    $query = $db->getQuery(true);
    $query->select('*')
     ->from('#__menu')      
     ->where('id = ' . $db->quote($Name));      
    $db->setQuery($query);
    $rows = $db->loadObjectList();

    foreach ($rows as $row){
        $row = $row->msg;
    }
    return $row;
}

echo getItemIdByName($Name); //echo the result of the function