气泡排序打印垃圾值

Question

I was curious on bubble sorting so I have made a function that takes user input and than stores the values in the posititons of an array but it keeps printing out some garbage value.

#include <stdlib.h>
#include <stdio.h>
#include <math.h>

void sort(int*z);
void swap(int* element1Ptr,int* element2Ptr);

int main(void)
{  
    int number[10];  
    int input;  
    int* sorting;  

    sorting = number;
    printf("Please enter a number less than 10 digits long");
    scanf_s("%d", &input);
    for (int i=0; i<10;i++)
    {
        number[9-i]=input%10;
        input/=10;
    }
    printf("\n");
    sort(sorting);
    printf("%d\n",number[0]);
}

do I have the bubble soriting code wrong or am I passing the wrong variable?

void sort(int* z)
{
    int pass; /* pass counter */  
    int j; /* comparison counter */  

    /* loop to control passes */  
    for ( pass = 0; pass < 11; pass++ ) 
    {
        /* loop to control comparisons during each pass */
        for ( j = 0; j < 10; j++ )
        {
             /* swap adjacent elements if they are out of order */
             if ( z[ j ] > z[ j + 1 ] ) 
             {
                 swap( &z[ j ], &z[ j + 1 ] );
             } /* end if */
        } /* end inner for */
    } /* end outer for */
}/* end function bubbleSort */

void swap(int* element1Ptr,int* element2Ptr)
{
    int hold = *element1Ptr;
    *element1Ptr = *element2Ptr;
    *element2Ptr = hold;  
} /* end function swap */  

Answer 1

The error I was having I was trying to print the first value in the array and that value would always be 0 if you didn't have a 10 digit number:

 printf("%d\n", number[0]);

should read

 printf("%d\n", number[9]);

and the loop I had bult to place the values in was placing them in the wrong spot so I fixed it like so

for (int i=0; i<10; i++)
{
     number[i] = input % 10;
     input /= 10;
}

that is all I changed and it worked fine.

Answer 2

Your number input code is a bit funky. Instead of entering a single long number and then using %10 to get the value of each digit, why not enter a set of 10 numbers?

for (int i=0; i<10;i++)
{
    scanf_s("%d", &input);
    number[i]=input;
}

Answer 3

Bubble sort should be

for ( pass = array_length - 2; pass >= 0; pass-- ) 
{
    for ( j = 0; j <= pass; j++ )
    {
       compare_and_swap(& z[j], & z[j + 1]);
    }

    // at this point in the code, you are guaranteed that 
    // every element beyond the index of pass is in the final
    // correct location in the array

    // so if you input array was {9, 8, 7, 6, 5}
    // and pass = 2
    // then elements 3 and 4 are correct here:
    // {*, *, *, 8, 9}
}

void compare_and_swap(int* a, int* b)
{
    if (*a > *b)
    {
        int temp = *a;
        *a = *b;
        *b = temp;
    }
}