使用Oledb Access的登录系统

Question

I made a login page were the employee type in employee email address and then their pin. The idea is for the program to check the email and the pin form a Access database to successfully log them in. This is the code that I used.

 private void Validate(object sender, RoutedEventArgs e)
    {
        OleDbConnection con = new OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;Data Source = C:\\Users\\Baladi\\documents\\visual studio 2012\\Projects\\CalUnderFoot\\CalUnderFoot\\UserPerm.mdb");           
        OleDbCommand cmd = null;
        OleDbDataReader dr = null;

        string cmdStr = String.Format("select * from UserPermT where EmpEmail='{0}' and EmpPIN='{1}'", EmpEmailtxt.Text, EmpPINtxt.PasswordChar);

        con.Open();
        cmd = new OleDbCommand(cmdStr, con);
        dr = cmd.ExecuteReader();

        cmd.Dispose();

        if (dr.Read() == true)
        {
            MessageBox.Show("success");
        }

        else
        {
            MessageBox.Show("fail");
        }

        dr.Dispose();
    }

When I enter the wrong email and pin I get a message saying "fail" which is what it supposed to do. BUT, when I enter the right email and pin I still get the "fail" message. What am I missing?? And yes I know... I am not supposed to store passwords in databases and I will encrypt them in due time. Thank you in advance

Answer 1

Try something like this:

private void Validate(object sender, RoutedEventArgs e)
    {

    using (OleDbConnection connection = new OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;Data Source = C:\\Users\\Baladi\\documents\\visual studio 2012\\Projects\\CalUnderFoot\\CalUnderFoot\\UserPerm.mdb"))
    {
        OleDbCommand command = new OleDbCommand("select * from UserPermT where EmpEmail='"+EmpEmail.Text+"' and EmpPIN='"+EmpPIN.PasswordChar+"'", connection);
        connection.Open();
        OleDbDataReader dr= command.ExecuteReader();

        if (dr.Read())
        {
            MessageBox.Show("success");
        }

        else
        {
            MessageBox.Show("fail");
        }
        dr.Close();
    }
    }

(from http://msdn.microsoft.com/en-us/library/979byfca.aspx )