等待创建数据库完成

Question

I have a code like this:

using (var sqlConnection = new SqlConnection(connectionString))
{
  sqlConnection.Open();
  using (var sqlCommand = new SqlCommand(scriptText, sqlConnection))
  {
    sqlCommand.ExecuteNonQuery();
  }
}

For the first time I call it to create a DB, then I form a connection string to this DB and try to do some work ( Open works fine and says the connection is actually open for this second connection). But I get an "An existing connection was forcibly closed by the remote host" and I can see the sql logs "Could not find database ID 9. Database may not be activated yet or may be in transition". So, actually the ExecuteNonQuery return before the job is done. Sure, I can just spam it until a situation changes, but is there a better way to wait for DB to be ready for work?

Answer 1

This complete sample works for me.

It creates the database, creates a table, puts a row in the table.

Not sure what is wrong on your end.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Data.SqlClient;

namespace GranadaCoder.PlaygroundConsole.SqlStuff
{
    public class SqlPlayground
    {

        public static void EntryPointStuff()
        {
            string databaseName = "MyFirstDatabaseABC";
            string connectionString = string.Empty;
            string commandText = string.Empty;
            int returnValue = 0;
            string msg = string.Empty;

            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder();
            builder["Initial Catalog"] = "master";
            builder["integrated Security"] = true;
            builder["Server"] = @"MyMachine\MyInstance";
            connectionString = builder.ConnectionString;


            commandText = string.Format("IF EXISTS (Select * from sys.databases where name = N'{0}') DROP DATABASE [{0}]", databaseName);
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);

            commandText = string.Format("IF NOT EXISTS (Select * from sys.databases where name = N'{0}') CREATE DATABASE [{0}]", databaseName);
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);

            /* Change the Catalog */
            builder["Initial Catalog"] = databaseName;
            connectionString = builder.ConnectionString;


            commandText = "if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[CodeCategory]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)    BEGIN       DROP TABLE [dbo].[CodeCategory]     END ";
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);

            commandText = "CREATE TABLE [dbo].[CodeCategory] (    CodeCategoryKey           [smallint] not null     , CodeCategoryName      varchar(64) not null  ) ";
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);


            commandText = "INSERT INTO [dbo].[CodeCategory] (     CodeCategoryKey       , CodeCategoryName    ) Select 1001 , 'MyFirstCodeCategory' ";
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);

            commandText = "Select Count(*) from [dbo].[CodeCategory]";
            returnValue = RunACommand(connectionString, commandText);
            msg = string.Format("'{0}', {1}", returnValue, commandText);
            Console.WriteLine(msg);

        }




        private static int RunACommand(string connectionString, string scriptText)
        {

            int returnValue = 0;

            using (var sqlConnection = new SqlConnection(connectionString))
            {
                sqlConnection.Open();
                using (var sqlCommand = new SqlCommand(scriptText, sqlConnection))
                {
                    returnValue = sqlCommand.ExecuteNonQuery();
                }
                sqlConnection.Close();
            }

            return returnValue;
        }






    }

}

This works for me (with no exceptions):

    static void Main(string[] args)
    {

        try
        {

            SqlPlayground.EntryPointStuff();

            Console.WriteLine("Press Enter after deleting the database in SSMS manually with 'Close Existing Connections' checked.");
            Console.ReadLine();

            SqlPlayground.EntryPointStuff();


        }
        catch (Exception ex)
        {
            Console.WriteLine(ex.Message);
        }


        Console.WriteLine("Pressing Enter To End");
        Console.ReadLine();

    }

Answer 2

In my case adding Thread.Sleep(...) helped, but the root cause was that the failed connection was cached and used by method SqlConnection.Open(). See answer for this question for this situation. Clearing the pool with SqlConnection.ClearAllPools() helps.

Why then waiting for some seconds helps too? Seems that it was enough to clear the pool automatically by timer.

Answer 3

You may notice this problem if you are doing someting else immediately(eg updating database schema) following the creation. Waiting for a few seconds seems to solve the problem.

//wait for database creation
Thread.Sleep(3000);