将int数组复制到Struct int *

Question

Hi I'm trying to read variables from a file into a int array so I can store them in a Struct array. The numbers get stored correctly into the curLinks array but when I try pass the curLinks array into curNodes.nodes, it doesn't work and when i try print it out (to test) it prints rubbish numbers. Any help would be great.

struct nodeInfo* getTopology(FILE *file){
    int totLinks=0;
    fscanf(file, "%d", &nodeCount);
    struct nodeInfo netTopo[nodeCount];

    // How many links does node have
    for (int id=0; id<nodeCount; id++){
        struct nodeInfo curNode;
        curNode.n=id;
        fscanf(file, "%d", &totLinks);
        int curLinks[totLinks];
        for(int i=0; i<totLinks; i++){
            int digit=0;
            fscanf(file, "%d", &digit);
            curLinks[i] = digit;
        }
        curNode.nodes = curLinks;

        netTopo[id] = curNode;
    }
    for (int id=0; id<nodeCount; id++){
        for (int j=0; j<3; j++){
            printf("%d ", netTopo[id].nodes[j]);
        }
    }

    return netTopo;
}

Answer 1

You define curLinks multiple time in the first for -loop

int curLinks[totLinks];

And after you fill that you try to set that in your nodeinfo however as soon as the next iteration in the for -loop is entered and curLinks is filled again, the memory of your previous curLinks is out of scope and the memory where you think your read in values should reside can be actually filled with anything - Undefined Behaviour

If you tell me the way you define your structs nodeInfo I might be able to show you how to do it properly.

eg: Assuming you define

struct nodeinfo {
    int *nodes;
};

Then

struct nodeInfo* getTopology(FILE *file)
{
    int id, digit=0, totLinks=0;
    fscanf(file, "%d", &nodeCount);
    struct nodeInfo netTopo[nodeCount];

    // How many links does node have
    for (id=0; id<nodeCount; id++){

        fscanf(file, "%d", &totLinks);

        netTopo[id].nodes = malloc(totLinks * sizeof(int));
        if (netTopo[id].nodes==NULL)
            printf("Error allocating memory\n");

        for(i=0; i<totLinks; i++) {
            fscanf(file, "%d", &digit);
            netTopo[id].nodes[i] = digit;
        }
    }

    // Free the allocate memory
    for (id=0; id<nodeCount; id++){
         free(netTopo[id].nodes);
    }

    return netTopo;
}

Answer 2

我认为在这种情况下，应该使用指针和“ malloc”从堆中分配内存。