为什么我的程序不将数据写入文本文件？

Question

The programme readS the file line by line.
If the programme finds in a line [@: Object successfully summoned] , it won't write to the second file.
Probably the problem is in the try/catch/finally part. I have tried many changes a few times, but i can't fix the problem.

This is what I have programmed:

package stringsHerkennen;

import java.io.BufferedReader;
import java.io.FileInputStream;
import java.io.FileWriter;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.PrintWriter;

public class MC {

    private static PrintWriter outputFile;

    /**
     * @param args
     * @throws IOException 
     */
    public static void main(String[] args) throws IOException{
        FileInputStream fstream = null;
        FileWriter fwriter = null;

        fstream = new FileInputStream("C:\\Users\\Tim\\Documents\\test.txt");
        BufferedReader br = new BufferedReader(new InputStreamReader(fstream));
        String strLine;
        fwriter = new FileWriter("bewerkte log.txt", true);
        outputFile = new PrintWriter(fwriter);
        try{
             while ((strLine = br.readLine()) !=null) {
                 try{
                 System.out.println(strLine);
                 String b = strLine;
                 String tokens[] = strLine.split("]: ");
                 String c = tokens[1].toString();
                 //System.out.println(tokens[1]);
                 Hamming H = new Hamming("[@: Object successfully summoned]", c);
                int Pi = H.getHammingDistance();
                //System.out.println(Pi);
                 if(!(Pi==0)){
                     //System.out.println("geschreven naar file");
                    outputFile.println(b);


                     //System.out.println("schrijven naar andere file");
                 }
                 else{
                     //System.out.println("niet geschreven naar file");

                 }


             //try2
             }
                catch(Exception ArrayIndexOutOfBoundsException){
                     //System.out.println("Schrijven naar File");

                     outputFile.println(strLine);

             }
             finally {
                     if (fstream != null)
                         fstream.close();}


             }

             //try1
        }
        catch(Exception ArrayIndexOutOfBoundsException){
                 fstream.close();
                 br.close();
        }
        finally {
                 if (fstream != null)
                     fstream.close();}
            System.out.println("klaar");


    }
}

This is the text file, that you want to filter

sun.nio.cs.StreamDecoder.readBytes(Unknown Source) ~[?:1.7.0_13]#-  at 
sun.nio.cs.StreamDecoder.implRead(Unknown Source) ~[?:1.7.0_13]
    at sun.nio.cs.StreamDecoder.read(Unknown Source) ~[?:1.7.0_13]
    at java.io.InputStreamReader.read(Unknown Source) ~[?:1.7.0_13]
    at java.io.BufferedReader.fill(Unknown Source) ~[?:1.7.0_13]
    at java.io.BufferedReader.readLine(Unknown Source) ~[?:1.7.0_13]
    at java.io.BufferedReader.readLine(Unknown Source) ~[?:1.7.0_13]
    at ll.run(SourceFile:78) [minecraft_server.1.7.2.exe:?]
[15:39:13] [Server thread/INFO]: Starting minecraft server version 1.7.2
[15:39:13] [Server thread/INFO]: Loading properties
[15:39:13] [Server thread/INFO]: Default game type: SURVIVAL
[15:39:13] [Server thread/INFO]: Generating keypair
[15:39:13] [Server thread/INFO]: Starting Minecraft server on *:25565
[15:39:13] [Server thread/INFO]: Preparing level "world 3"
[15:39:13] [Server thread/INFO]: Preparing start region for level 0
[15:39:14] [Server thread/INFO]: Done (0,820s)! For help, type "help" or "?"
[17:09:01] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:01] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:01] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:01] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]
[17:09:02] [Server thread/INFO]: [@: Object successfully summoned]

Answer 1

Your code is a little messy and hard to follow. I'd write it more like this:

package stringsHerkennen;

import java.io.*;


public class MC {
    /**
     * @param args
     * @throws IOException
     */
    public static void main(String[] args) throws IOException {
        FileInputStream fstream = null;
        FileWriter fwriter = null;
        PrintWriter outputFile = null;

        try {
            fstream = new FileInputStream("C:\\Users\\Tim\\Documents\\test.txt");
            BufferedReader br = new BufferedReader(new InputStreamReader(fstream));
            String strLine;
            fwriter = new FileWriter("bewerkte log.txt", true);
            outputFile = new PrintWriter(fwriter);
            while ((strLine = br.readLine()) != null) {
                String tokens [] = strLine.split("]: ");
                if ((tokens != null) && (tokens.length > 0)) {
                    Hamming H = new Hamming("[@: Object successfully summoned]", tokens[1]);
                    int Pi = H.getHammingDistance();
                    if (Pi != 0) {
                        outputFile.println(b);
                    } else {
                    }
                }
            }
        } catch (IOException e) {
            e.printStackTrace(); 
        } finally {
            closeQuietly(outputFile);
            closeQuietly(fwriter);
            closeQuietly(fstream);
        }
    }

    public static void closeQuietly(InputStream is) {
        try {
            if (is != null) {
                is.close();
            }
        } catch (IOException e) {
            // Quietly....log the exception if you like
        }
    }

    public static void closeQuietly(Reader r) {
        try {
            if (r != null) {
                r.close();
            }
        } catch (IOException e) {
            // Quietly....log the exception if you like
        }
    }

    public static void closeQuietly(Writer w) {
        try {
            if (w != null) {
                w.close();
            }
        } catch (IOException e) {
            // Quietly....log the exception if you like
        }
    }
}

Answer 2

I believe it is bad practice to place code to be executed in the Catch block. However are you flushing the output from the PrintWriter?

outputFile.flush(); 

might be what your looking for if the contents aren't being placed into the second file.

Answer 3

1) remove the finally block inside the while loop 2) add outputFile.flush() in the finally block after the loop

                //try2
            } catch (Exception ArrayIndexOutOfBoundsException) {
                //System.out.println("Schrijven naar File");

                outputFile.println(strLine);

            } 
             //**COMMENT this fstream is being closed in the while loop !!!

             /*finally {
                if (fstream != null)
                    fstream.close();
            }*/


        }

        //try1
    } catch (Exception ArrayIndexOutOfBoundsException) {
        fstream.close();
        br.close();
    } finally {
        outputFile.flush(); // ADD THIS TO FLUSH TO DISK
        if (fstream != null)
            fstream.close();
    }
    System.out.println("klaar");