使用Web服务代理在类中实现IDisposable

Question

The one area of .NET that's always befuddled me is exactly when to implement the IDisposable pattern.

I have created a SOAP web service proxy using WSDL which implements IDisposable on the Component base class:

public partial class WSDLGeneratedProxy : System.Web.Services.Protocols.SoapHttpClientProtocol

I have created sort-of facade interface with simplified methods so that I could hide the service proxy interactions behind, and made it implement IDisposable:

public interface IServiceClient : IDisposable

I have an implementation of the IServiceClient and that implementation contains an actual member of WSDLGeneratedProxy

public class FacadeServiceClient : IServiceClient
{
    private WSDLGeneratedProxy clientProxy;
}

So my question is - should I call the Dispose method on the service proxy explicitly? Is that the proper way to do it?

public void Dispose()
{
    this.Dispose(true);
    GC.SuppressFinalize(this);
}

protected virtual void Dispose(bool disposing)
{
    if (disposing)
    {
        if (clientProxy != null)
        {
            clientProxy.Dispose();
        }
    }
}

Any suggestions or input is greatly appreciated.

Answer 1

I don't see any reason for which you would have to dispose that object, it's going to be garbage collected anyways when it's no longer used.

IDisposable interface base use is to dispose unmanaged objects (check Proper use of the IDisposable interface )

That's the reason why we use using with for example System.IO classes like FileStream

      using (var fs = new FileStream(filePath, mode)) 
       {
              //use fs 
       }

When the compiler encounters using keyword it will rewrite the code into something like

        FileStream fs = new FileStream(filePath, mode); 
        try 
        {
            //use fs
         }
        finally 
        {
            //compiler will automatically call dispose on the FileStream to free up unmanaged objects
             fs.Dispose(); 
         }

You may also want to use dispose when you work with huge objects in memory (like hundreds of MB) and do not wish to wait for the GC to collect them but rather do it earlier.

If you're not in any of the mentioned above situations then the GC will for sure do better work in disposing the objects than you will do.