如何遍历哈希图并在数组列表中找到字符串的最大值？

Question

This is the code I have so far for my homework and I'm at a dead end here. The idea is tis is a scrabble like deal where i get a string of words and then I have to go through each word to get its total value based on a dictionary in a hash map containing letters and integer values. I'm no sure how to implement this an would appreciate some direction.

public class ScrabbleAssistant 
    { 
    int maxScore = 0;
    String bestWord = "";
    int totalScore = 0;
    String getBestWord(List<String> options, Map<Character, Integer> letterscores)
    { 
        for (int i = 0; i < options.size(); i++) 
     {
        totalScore = 0; 
     }
        for (int j = 0; j < letterscores.size(); j++) 

        if (totalScore > maxScore)
    {
        maxScore = totalScore;

        return totalScore;   

    }
    Integer getScore(String word, Map<Character, Integer>letterscores, Integer total)
    {
       for (int i = 0; i < letterscores.size(); i++) 
    {
       totalScore = total + letterscores.remove(i);
    }
        if (totalScore > maxScore)
    {
        maxScore = totalScore;
        bestWord + word;
    }
        return totalScore;
    }
}

Answer 1

Okay, this code will not work until you go through it, read all of the comments, and fill in the missing parts. I am pretty sure I found every issue, and I even fixed a few for you. Please do ask if anything is unclear, all changes are documented in the comments and I would be happy to clarify. If it still doesn't work after you make the changes, we can go from there as I may have missed something. All of the comments can be removed as you understand the changes.

Also, it seems strange that you are passing in the Map of letterScores as a parameter, is this a requirement of your homework?

Note the formatting of this code, it is very important to keep your code clean and easy to read. This ensures that others can understand your code quickly, and that you may spot bugs more quickly. These are Java coding conventions , something you should definitely read and adhere to. If you are using an IDE such as eclipse, you can typically select all of the code (CTRL+A) and auto indent it (CTRL+I). If you are using something else, you can google for the commands to do this.

public class ScrabbleAssistant { 
    //int maxScore = 0;  
    //String bestWord = "";  moved into getBestWord(), does not need class scope
    //int totalScore = 0; moved into methods, class scope could cause issues

    // added public, do not forget to give your methods a scope, changed letterScores to camelCase for readability
    public String getBestWord(List<String> options, Map<Character, Integer> letterScores) {
        String bestWord = "";
        int maxScore = 0;
        int totalScore;

        for (int i = 0; i < options.size(); i++) {

            totalScore = //what method should go here? hint: calculates the score of the given word

            if (totalScore > maxScore) {
                maxScore = totalScore;
                bestWord = // what is the best word? hint: its the current index of options 
               //return totalScore; //this is the wrong place to make a return, and you can't return an int in a class that returns a String  
             }
        }
        return // what should you return here? hint: must be a string
    }

// added public, do not forget to give your methods a scope, chnaged letterScores to camelCase for readability, removed Integer total parameter, was unnecessary
    public Integer getScore(String word, Map<Character, Integer>letterScores) {
        int totalScore = 0;

        for (int i = 0; i < word.length(); i++)  { // you were iterating through the map of letter scores, not the actual String passed in
            // you should not remove, you should use get the score of the letter from the current index of the string
            // this is fixed for you
            totalScore = totalScore + (letterScores.get(word.charAt(i).intValue();
        }

        //if (totalScore > maxScore){  This logic should not be here, this method should return the total score
        //maxScore = totalScore;
        //bestWord + word;
        //}
        return totalScore;
    }
}