在同一函数中多次返回$ q.promise（不同条件）时，Angular 1.2 $ q中断

Question

$scope.model.initJobs = function(forceLoad){
    var deferred = $q.defer();
    var companyId = authService.getCompanyId();
    if(!Boolean(companyId) || companyId == 'undefined'){//no data was loaded yet - bummer
        deferred.resolve([]);
        return deferred.promise;
    }
    var jobs = jobsService.getJobs(companyId);
    if(jobs && !forceLoad){
        deferred.resolve(jobs);
        return deferred.promise;
    }

    $scope.__loading = true;
    jobsService.getCompanyJobs(companyId).then(function(data){
        $scope.__loading = false;
        jobsService.setJobs(data.data, companyId);
        deferred.resolve(data.data);
    },
    function(errorData){
        $scope.__loading = false;
        $location.path('/notfound');
        jobsService.setJobs([], companyId)//those line are a precuation
        deferred.resolve(data.data);
    });
    return deferred.promise;
}

 $scope.model.initJobs(true).then(function(data){
      $scope.model.jobs = data;
  });

The following freezes the screen with Angular 1.2.0 and 1.2.1, is it because I am returning the defrred.promise on several occasions within the same function?. The idea here is not to load the data again if I already have it stored within my service.

Any thoughts?. Any help is appreciated & welcome.

EDIT: I should perhaps mention that ht above works perfectly fine on AngularJS 1.0.8!

Answer 1

You are making it way harder than it needs to be, generally you never need deferreds.

$scope.model.initJobs = function (forceLoad) {
    var companyId = authService.getCompanyId();
    if (!Boolean(companyId) || companyId == 'undefined') { //no data was loaded yet - bummer
        return $q.resolve([]);
    }
    var jobs = jobsService.getJobs(companyId);
    if (jobs && !forceLoad) {
        return $q.resolve(jobs);
    }

    $scope.__loading = true;
    return jobsService.getCompanyJobs(companyId)
    .then(function (data) {
        jobsService.setJobs(data.data, companyId);
        return data.data;
    })
    .catch(function (errorData) {
        $location.path('/notfound');
        jobsService.setJobs([], companyId) //those line are a precuation
        //You seem not have tested because this won't work
        return data.data;
    })
    .finally(function() {
         $scope.__loading = false;
    });
}