为什么我的“保存”按钮不起作用？

Question

I have one of the biggest problem in my program. I've created Save button, but it saves if the .txt file is new (Then that button does "SaveAs" function). But when I open file, then type something and trying to save and it's not saving :S. Can anyone help me?

Here's the code:

fileSave.addActionListener(new ActionListener() {
    public void actionPerformed(ActionEvent e) {
        if(currentFile == null) {
            int saveResult = fileSelect.showSaveDialog(null);
            if(saveResult == fileSelect.APPROVE_OPTION) {
                saveFile(fileSelect.getSelectedFile(), field.getText());            
            } else {
                saveFile(currentFile, field.getText());
            }
        }
    }
});

public void saveFile(File file, String contents) {
    BufferedWriter writer = null;
    String filePath = file.getPath();
    if(!filePath.endsWith(".txt")) {
        filePath += ".txt";
    }

    try {
        writer = new BufferedWriter(new FileWriter(filePath));
        writer.write(contents);
        writer.close();
        field.setText(contents);
        setTitle("Editex - " + filePath);
        currentFile = file;
    } catch (Exception e) {

    }
}

Answer 1

You aren't handling when currentFile != null, which is what I am assuming is the case when you are trying to save a file that already has a Filename.

Do something like this:

if(currentFile == null) {
    // Handle if new file
} else {
    // Handle an existing file
}

Move

saveFile(currentFile, field.getText());

into the else part of the above if else.

At the moment you have it within the if(currentFile == null) , and this isn't the correct place as you are calling saveFile(null, field.getText()) here.

---

Also

catch(Exception e) {

}

is bad, never swallow an exception and do nothing with it, you will never know if an exception happens or not, just nothing will happen.