目标C中选择器上的EXC_BAD_ACCESS

Question

I've got a UIBarButtonItem category where I build UIBarButtonItems with custom UIButtons, since I've found UIButtons easier to customize then UIBarButtonItems.

Now, I'd like to continue to use the BarButtonItem's target and action properties instead of using those in the button so that the BarButtonItem can continue to be customized externally without anyone having to know the implementation details (ie, that it is using a button internally).

Now, in order to do that, I'm written up this code in my category:

+ (UIBarButtonItem *)backBarButtonItemWithColor:(UIColor *)color 
{
    UIImage *closeIcon = [MyImageUtility navBarBackArrow];
    if (color) closeIcon = [closeIcon imageWithColorOverlay:color];

    UIButton *close = [[UIButton alloc] initWithFrame:CGRectMake(0.0f, 0.0f, closeIcon.size.width+10.0f, closeIcon.size.height+10.0f)];
    UIBarButtonItem *item = [[UIBarButtonItem alloc] initWithCustomView:close];
    [close setImage:closeIcon forState:UIControlStateNormal];

    [close addTarget:item action:@selector(SD_executeBarButtonItemAction) forControlEvents:UIControlEventTouchUpInside];

    return item;
}


- (void)SD_executeBarButtonItemAction
{
    [self.target performSelector:self.action];
}

Whenever the SD_executeBarButtonItemAction is called, I get a exc_bad_access on the selector, though I am not sure why. Any ideas? Is there a way around this?

Thanks!

EDIT:

here is the code being called by that selector that is crashing:

void (^transition)(void) = ^(void) {
    [self.rightContainer  setFrame:[self offscreenContainerFrame]];
    [self.centerContainer setAlpha:1.0f]; //TODO: this is unreliable in iOS6 -- we should add a view to the top of it to darken
    [self.centerContainer setTransform:CGAffineTransformIdentity];
};

[self notifyWillShowPrimaryViewController];

[self performBlock:transition animated:YES completion:^(BOOL finished) {
    [self notifyDidShowPrimaryViewController];
    [self setForegroundController:self.primaryNavigationController];
    if (block != NULL) block(finished);
}];

Answer 1

Your code is a recursive call.

- (void)SD_executeBarButtonItemAction
{
    [self.target performSelector:self.action];
}

You set like:

[close addTarget:item action:@selector(SD_executeBarButtonItemAction) forControlEvents:UIControlEventTouchUpInside];

Where item is a UIBarButtonItem .