回显字符串中的php变量

Question

I'm customizing a wordpress for the first time so I'm pretty new with PHP langage and something is driving me crazy. I wrote that function to transform my HTML5/CSS3/JQUERY layout into a CMS:

<?php $property = simple_fields_values("pillow_front");
  foreach ($property as $value) {
    echo "<div class='solo'>";
      echo "<div class='box coussin'>";
        echo "<div class='outImg'><img src='" . wp_get_attachment_url($value) . "'/></div>";
      echo "</div>";
    echo "</div>";
  }
?>

But in the front-end it doesn't work and when I look at the code it appears that the img tag is not closed properly:

<div class="solo">
  <div class="box coussin" style="width: 328px; height: 328px;">
    <div class="outImg" style="opacity: 1;">
      <img src="http://localhost:8888/wp-content/uploads/2014/01/021.jpg" style="width: 328px; height: 328px;">
    </div>
  </div>
</div>

I didn't really well understoud if the . in PHP was the exact equivalent of the + in javascript but I tried a lots of thing and I can get that tag to be properly closed !

Thank you

Answer 1

You can print in another system, something like this:

<?php 
$property = simple_fields_values("pillow_front");
 foreach ($property as $value) {
 ?>
  <div class='solo'>
   <div class='box coussin'>
    <div class='outImg'><img src="<?php print wp_get_attachment_url($value);?>"/></div>
   </div>
  </div>
 <?php
 }
 ?>

Please note that i put the echo of the function only because i do not know how it works, it can be not necessary, use php only when needed.

Answer 2

Or just a bit more MVC-Pattern or in that case just MV? ;) Try this one without Wordpress.

<?php

    //Init
    $property = simple_fields_values("pillow_front");
    $template = '<div class="solo">
       <div class="box coussin">
        <div class="outImg"><img src="{MARKER:FRONT}" /></div>
       </div>
      </div>';

    foreach ($property as $value) {
        echo str_replace(array('{MARKER:FRONT}'), array($value), $template);
    }
?>

And as i know wordpress view, your code style is not confirm to WP-Styleguide. WP is using HTML/PHP Templating. In WP you view need to look like this.

<?php foreach(simple_fields_values("pillow_front") as $value): ?>
<div class='solo'>
    <div class='box coussin'>
        <div class='outImg'><img src="<?php echo htmlentities(value): ?>"/></div>
    </div>
</div>
<?php endforeach; ?>