存储库模式中的共享服务

Question

I am wondering how to deal with a situation when inside one service lets say ICompanyService I need to call another method from IUserAccountService . ?

So generally lets say that a Company shouldn't exist without an UserAccount .

The IUserAccount implementation service class looks like this:

public class UserAccountService : CrudService<UserAccount>, IUserAccountService
{
    private readonly IRepository<UserAccount> _userAccountRepository;
    private readonly IUnitOfWorkFactory _unitOfWorkFactory;

    public CompanyService(IRepository<UserAccount> userAccountRepository,
                          IUnitOfWorkFactory unitOfWorkFactory)
        : base(userAccountRepository, unitOfWorkFactory)
    {
        _userAccRepository = userAccRepository;
    }

    public int RegisterUser(UserAccount user) {

        using (var uow=_unitOfWorkFactory.Create())
        {
           // Details omitted for brievity
           var userId = _userAccountRepository.Create(user);
           uow.Commit();
           return userId;
        }
    }

   //Other service methods

}

The company ICompanyService implementation:

public class CompanyService : CrudService<Company>, ICompanyService
{
    private readonly IRepository<Company> _companyRepository;
    private readonly IUnitOfWorkFactory _unitOfWorkFactory;

    public CompanyService(IRepository<Company> companyRepository,
                          IUnitOfWorkFactory unitOfWorkFactory)
        : base(companyRepository, unitOfWorkFactory)
    {
        _companyRepository= companyRepository;
    }

    public int CreateCompanyWithUserAccount(Company company) {

        using (var uow=_unitOfWorkFactory.Create())
        {
           // Some validation with the company.Details omitted for brievity
           // Here I need an instance of IUserAccountService
           // Suppose I get it through DI or IoC
           var userAccountService = IoC.Resolve<IUserAccountService>();
    ###    // Is such approach good or bad?!    ###
           var userId = userAccountService.RegisterUser(company.UserAccount);
           // Map the user id to the company
           company.UserAccount.Id = userId;
           var companyId = _companyRepository.Create(company);
           uow.Commit();
           return companyId;
        }
    }

   //Other service methods

}

ORM under the repository is: NHibernate

Answer 1

You could just take a dependency on the IRepository<UserAccount> :

public class CompanyService : CrudService<Company>, ICompanyService
{
    private readonly IRepository<Company> _companyRepository;
    private readonly IRepository<UserAccount> _userAccountRepository;
    private readonly IUnitOfWorkFactory _unitOfWorkFactory;

    public CompanyService(IRepository<Company> companyRepository,
                          IUnitOfWorkFactory unitOfWorkFactory
                          IRepository<UserAccount> userAccountRepository)
        : base(companyRepository, unitOfWorkFactory)
    {
        _companyRepository= companyRepository;
        _userAccountRepository = userAccountRepository;
    }

    public int CreateCompanyWithUserAccount(Company company) {

        using (var uow=_unitOfWorkFactory.Create())
        {
           // Some validation with the company.Details omitted for brievity
           var userId = _userAccountRepository.Create(company.UserAccount);
           // Map the user id to the company
           company.UserAccount.Id = userId;
           var companyId = _companyRepository.Create(company);
           uow.Commit();
           return companyId;
        }
    }

   //Other service methods

}

IMO, it's better to take a dependency on the repository. After all your company service is creating a company and it needs to do some work in the database, which is what the repositories are for. From what I can see in the code, there's no need to involve the UserAccountService .

Answer 2

1. Seems you have wrong constructor in UserAccountService implementations: public CompanyService

2. In CompanyService implementation, you better resolve IUserAccountService dependency right in a constructor, so you do it once per object creation, not each time you call method.

3. There's no problems with those dependencies. If two objects of IUnitOfWorkFactory implementations are problem -> make a singleton