PHP脚本耗尽内存

Question

Hi im trying to code a funktion that will import trailers from a remote server The code is matching product in our magento store with the trailers on the trailer server . The problem is that the script eating up all memory. is there any way of optimize this to not consume memory .

here are my function

    function getTrailers() {

    echo "<pre>\n";
    $this->_acquireLock();

    $_productCollection = Mage::getModel('catalog/product')->getCollection()

      ->addAttributeToFilter('attribute_set_id', array('eq' => '9'));
     //->addAttributeToFilter('Sku', array('eq' => '843594'));


    $this->_logLine(sprintf("Starting import of Trailers" ));
    $i=0;
        $server = "http://trailer.server.com/trailers";
        foreach($_productCollection as $product) {
        $thispro  =  Mage::getModel('catalog/product')->load($product->getId());
        $attributeValue = $thispro->getFaktaId();

            //echo memory_get_usage() . "<br>\n";
            //echo memory_get_peak_usage() . "<br>\n";

        if($thispro->getMainTrailer()=="") {
            if($attributeValue != "") {
                $im = $attributeValue.".mp4";
                    $url = $server.$im;


        $exist = $this->file_exists_remote($url);


        if($exist) {
            $i++;
            $product->setMainTrailer($url);
            $product->save();
        } else {

            }
        }
    }
}
    $this->_logLine(sprintf("Imported %d Trailers...", $i));
    $this->_releaseLock();

    echo "</pre>\n";

}

Answer 1

You could reuse the same model instance in the loop:

foreach($_productCollection as $product)
{
    $product->load($product->getId());
    // ...

    $product->clearInstance();
}

or even better only load the stuff you need in the collection

$_productCollection = Mage::getModel('catalog/product')->getCollection()
      ->addAttributeToFilter('attribute_set_id', array('eq' => '9'))
      ->addAttributeToSelect(array('fakta_id', 'main_trailer'));

and then loop through without needing to reload the product:

foreach($_productCollection as $product)
{
   $attributeValue = $thispro->getFaktaId();
   // ...
}

Answer 2

Your main problem is that you keep collection of products you never use. Actually you don't need these products. You only need their IDs.

So you have to edit your code like this:

function getIds() {
    return Mage::getModel('catalog/product')->getCollection()
        ->addAttributeToFilter('attribute_set_id', array('eq' => '9'))
        ->getAllIds();
}

...
foreach(getIds() as $id) {
    $thispro = Mage::getModel('catalog/product')->load($id);
    ...
    // Further you have to replace all $product occurences with $thispro
}

Answer 3

The following article describes about different ways to prevent running php out of memory.

http://v1.srcnix.com/2010/02/10/7-tips-to-prevent-php-running-out-of-memory/

Answer 4

How large is $_productCollection? You could try getting the products in batches or removing the product from the collection at the end of the for-loop.