如果语句未在Python中的模块内部执行

Question

I'm confused, the if statement should by all means run imo, but of course this is programming so its not going to work.

def create_player():
    name = str()
    names = []
    print("hey there")
    if numberofplayers == 2:
        name = input("Please enter Player 1's name: ")       
        names.append(name)
        name = input("Please enter Player 2's name: ")
        names.append(name)
    elif numberofplayers == 3:
        name = input("Please enter Player 1's name: ")       
        names.append(name)
        name = input("Please enter Player 2's name: ")
        names.append(name)
        name = input("Please enter Player 3's name: ")
        names.append(name)
    elif numberofplayers == 4:
        name = input("Please enter Player 1's name: ")       
        names.append(name)
        name = input("Please enter Player 2's name: ")
        names.append(name)
        name = input("Please enter Player 3's name: ")
        names.append(name)
        name = input("Please enter Player 4's name: ")
        names.append(name)
        print("Welcome to the game " + names[0] + ", " +names[1]+ ", "+names[2]+ " and "+names[3]+"!")

print("test")
numberofplayers = int(0)
numberofplayers = input("# of players")
create_player()
print ("aha")

(By the way this code is not be any means anywhere near finished) The random print operations were there for testing, the program seems to ignore the whole if statement, as it prints all of the print operations outside of the if statement, but none that are inside the statement. Any help would be very much appreciatted, thank you in advance.

Answer 1

You need to cast numberofplayers to int , otherwise you are comparing and int and a string :

numberofplayers = int(input("# of players"))

input() in Python 3 returns a string object, in difference with former Python2's input() .

This is what is going on:

>>> a = input()
2
>>> a == 2
False
>>> a == '2'
True

Answer 2

While Paulo's answer fixes your immediate problem, there's a few other things to point out.

• Since your function creates at least two players, name if correctly: create_players . It avoids confusion later.

• Don't rely on globals or values outside of your function scope. You should pass them explicitly into your functions.

   def create_players(numberofplayers): ... numberofplayers = int(input('# of players')) create_players(numberofplayers) 

• These lines don't do anything useful:

   name = str() numberofplayers = int(0) 

  You don't need to define variables as types in order to use them, and you're immediately replacing these with real values.

• Your branching if-elif would be better as a single for loop:

   names = [] for player in range(1, numberofplayers+1): names.append( input("Please enter Player %d's name: " % player) ) print('Welcome to the game ' + ' and '.join([', '.join(names[:-1]), names[-1]]) + '!')