如果为其他语句，则获得两倍的输出

Question

In my IRC Bot, as soon as someone types !highfivetest the bot gives out a message twice. Is something wrong with my if-else?

Arry String;

public String[] moderatoren = {"furby1987","furbybot"}; // Moderatoren

CmdOutput;

        if (message.equalsIgnoreCase("!highfivetest")){
            for(int i2 = 0; i2 < moderatoren.length; i2++){  
                if (sender.equals(moderatoren[i2])){
                    sendMessage (channel, "!highfive");
                }else{              
                    sendMessage(channel, "Nur eingetragene Moderatoren haben Zugriff auf diesen Befehl. Sry <3"); 
                }
            }
        }

Usually, i just type it that way;

            if (message.equalsIgnoreCase("!highfivetest")){
                for(int i2 = 0; i2 < moderatoren.length; i2++){  
                    if (sender.equals(moderatoren[i2])){
                        sendMessage (channel, "!highfive");
                    break;
                    }else{              
                        sendMessage(channel, "Nur eingetragene Moderatoren haben Zugriff auf diesen Befehl. Sry <3"); 
                    break;
                    }
                }
            }

But are the breaks really needed? just a bit irritated right now :-)

Greetings!

Answer 1

The error message should be sent outside the for loop. Otherwise it will be printed for every moderator that did not send the !highfivetest message. To simplify the code, you could change the array of moderators to a List and then use the List.contains method.

Example 1:

boolean vonModeratorGesendet = false;
for (int i2 = 0; i2 < moderatoren.length; i2++) {
    if (sender.equals(moderatoren[i2])) {
        vonModeratorGesendet = true;
        // you could also send "!highfive" from here
        break;
    }
}
if (vonModeratorGesendet) {
    sendMessage (channel, "!highfive");
} else {
    sendMessage(channel, "Nur eingetragene Moderatoren haben Zugriff auf diesen Befehl. Sry <3");
}

Example 2:

List<String> moderatorenListe = Arrays.asList(moderatoren);
if (moderatorenListe.contains(sender)) {
    sendMessage (channel, "!highfive");
} else {
    sendMessage(channel, "Nur eingetragene Moderatoren haben Zugriff auf diesen Befehl. Sry <3");
}

Example 2 is the better option. Instead of converting the array to a List , you could also use a List at all the time (that's what I would do).

Answer 2

您的if-else很好，问题可能出在for循环中或其他地方。

Answer 3

replace the breaks with continues, it's a loop you're running.

            if (message.equalsIgnoreCase("!highfivetest")){
            for(int i2 = 0; i2 < moderatoren.length; i2++){  
                if (sender.equals(moderatoren[i2])){
                    sendMessage (channel, "!highfive");
                continue;
                }else{              
                    sendMessage(channel, "Nur eingetragene Moderatoren haben Zugriff auf diesen Befehl. Sry <3"); 
                continue;
                }
            }
        }

That should work, continue is the c++ syntax for it as I'm unfamiliar with java but if you hunt there will be a similar line in the java language if it isn't continue.