从服务器PHP下载文件-文件略有关闭

Question

I hope this is a simple and quick fix. I have looked on here already to learn how to force download a file from the server. Here is what I am using below:

<?php
// Sending the file - a pdf in this case
header('Content-type: application/octet-stream');

// Specify what the  file will be called
header('Content-Disposition: attachment; filename="1234.txt"');

// And specify where it is coming from 
readfile('C:\test\1234.txt');
?>

It should be pretty self explanatory but I have a text file saved at C:\\test\\1234.txt.

I link to my php file (that has the above code) which is called download.php using this from the HTML page:

<a href="/download.php" title="Download This PDF">Download This File!</a>

---

OK now the problem.. My original text file is this:

test

but when I download the file, the result is a carriage return above:

_
test

The problem isn't huge with the text file, but because of this issue, all other files downloaded are corrupt and I believe this is why. I am hoping that someone has a solution to this that is pretty simple.

Thanks in advance!

Answer 1

You might try removing the PHP closing tag. Note this quote from php.net

If a file is pure PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script.

Perhaps that's where you're getting the extra carriage return.