点击前点击事件触发器

Question

I have a function that opens dialog windows. When the user clicks on the sign up button the sign up dialog should open. However, the dialog opens as soon as the page loads. If I use an anonymous function to handle the event it works fine, but I want to reuse the openDialog function for other dialogs (login, etc) so I don't want it to be anonymous.

var ready;
ready = function () {
    $('.js-join-button').on('click', openDialog(event, signUp));

    function openDialog(event, dialogType) {
        event.preventDefault ? event.preventDefault() : event.returnValue = false;
        dialogType.dialog('open');
    }
...
}
$(document).ready(ready);

Answer 1

You need to wrap your function in an anonymous function. Your code will run through and simply trigger the function otherwise.

$('.js-join-button').on('click', function() {
    openDialog(event, signUp)
});

Now, for example, if your function did not take any parameters, you could do

 $('.js-join-button').on('click', openDialog);

This passes a reference to the function. With the () it triggers the function. Without, it's a function reference.