Process.Start（）什么都不做

Question

I have to start a VPN connection (Fortinet) by code. I have a cmd file that establish the connection. If I call the cmd file on the shell it works pretty fine. When I call it via Process.Start it does nothing. It doesn't throw any exception, it seems to execute but VPN does not connect.

On the standard output I can read the echo I put on the cmd file (so it is executing the right file). I launched a ping -d to see when the vpn goes up, when I call it via shell it goes up in a few seconds, via C# it is not.

I also tried a sleep(30000) but nothing.

My cmd (ConnectFile.cmd):

@echo off
@echo Connecting to VPN
"C:\Program Files (x86)\Fortinet\SslvpnClient\FortiSSLVPNclient.exe" connect -s "vpn myvpn"

My code (connectFile and disconnectFile are strings that contain the full path of the cmd files):

try
{
    var startInfo = new System.Diagnostics.ProcessStartInfo();
    startInfo.FileName = connectFile;
    startInfo.WorkingDirectory = System.IO.Path.GetDirectoryName(connectFile) ?? "";
    System.Diagnostics.Process process = System.Diagnostics.Process.Start(startInfo);
    System.Threading.Thread.Sleep(30000);
    base.GetFiles(folder);
}
finally
{
    System.Diagnostics.Process.Start(disconnectFile);
}

Answer 1

You have to separate the parameters. FileName is for the exe file, not the whole shell command (you're explicitly saying not to use the shell). So put the parameters to the Arguments property in ProcessStartInfo .

In your case, the parameters should be:

• FileName - C:\\Program Files (x86)\\Fortinet\\SslvpnClient\\FortiSSLVPNclient.exe (no quotes)
• Arguments - connect -s "vpn myvpn" (again, no quoting)

Second, you have to read the standard output if you capture it. If the output buffer gets full before you read it, the called process will stop working - it has to wait for the buffer to be emptied. If you're sure the application will actually finish at some point, simply remove the Thread.Sleep and call ReadToEnd right away. Otherwise, use eg. asynchronous reading to get the data.

Also, it's usually a good idea to set WorkingDirectory . Even if the application doesn't need any data from the working directory, it's safer, since only admins can change Program Files - this helps against DLL inject hacks.