onclick javascript将值发送到另一个控件

Question

I would like to send value from EmployeeName to a sharepoint text filter control but the entire page freezes up when I use the following code

<div class="ui-widget">
    <label for="EmployeeName">
        Type Employee Name</label>
    <input id="EmployeeName">   
    <input type="button" value="OK" onclick="javascript:moveValue()" id="btnSearch" name="btnSearch" /> 
</div>



<script type="text/javascript">
    function moveValue() {
    var searchTXT = document.getElementById("EmployeeName").value;
    document.getElementById("ctl00_m_g_ae01f1bd_e6a3_4044_8045_ab8b29c41f89_SPTextSlicerValueTextControl").value = SearchTXT;
    }
<script>

Answer 1

I think there are a couple of things that you can do to improve your snippet.

To start the onclick="" syntax does not need javascript: part, you use javascript: only inside anchor tag hrefs, so that would change to

<input type="button" value="OK" onclick="moveValue()" id="btnSearch" name="btnSearch"/>

Secondly your <input id="EmployeeName"> should have a type specified and probably a value (I don't know if you omitted it for the purpose of the example)

eg

<input id="EmployeeName" type="hidden" value="John Smith" />

Lastly your function moveValue is susceptible to null reference exceptions.

I would change it to:

function moveValue() {
   var employeeField = document.getElementById("EmployeeName");
   var otherControl = document.getElementById("ctl00_m_g_ae01f1bd_e6a3_4044_8045_ab8b29c41f89_SPTextSlicerValueTextControl");
   //Making sure both fields are not undefined before accessing their properties.
   if(employeeField && otherControl){
      otherControl.value = employeeField.value;       
   }else{
     //Use for debugging, delete/comment once done
     alert("employeeField: " + employeeField  + ", otherControl: " + otherControl);
   }
}

See if this helps.