在SQL表中插入1000多行

Question

I have code that gets thousands of object ids from a website and I noticed that I was only able to write up to 1000 rows in a SQL Table using this code. How do write more than 1000 rows into a SQL table? The data I am inserting the table is not coming from another database, it is dynamically generated from other code.

var conn = new SqlConnection(masterData.DictRunData["ConnectionStringLocalDb"]);
const string objectName = "NotAvailable";
var dt = DateTime.Now;
var cmd = new SqlCommand("insert into CorporateDataStructure.dbo.ObjectInventory (location, object_name, object_id, object_xpath, time) values (@location, @object_name, @object_id, @object_xpath, @time)", conn);

foreach (var pair in webidsAndXPaths)
{
    conn.Open();
    cmd.Parameters.Clear();
    cmd.Parameters.Add(new SqlParameter("@object_name", objectName));
    cmd.Parameters.Add(new SqlParameter("@object_id", pair.Key));
    cmd.Parameters.Add(new SqlParameter("@object_xpath", pair.Value));
    cmd.Parameters.Add(new SqlParameter("@time", dt));

    cmd.ExecuteNonQuery();
    conn.Close();
}
return true;

Answer 1

var conn = new SqlConnection(masterData.DictRunData["ConnectionStringLocalDb"]);
            const string objectName = "NotAvailable";
            var dateTime = DateTime.Now;

            // create the datatable
            var table = new DataTable();
            table.Columns.Add("location", typeof(string));
            table.Columns.Add("object_name", typeof(string));
            table.Columns.Add("object_id", typeof(string));
            table.Columns.Add("object_xpath", typeof(string));
            table.Columns.Add("time", typeof (DateTime));

            // then loop all dictionary entries and add the rows
            foreach (var pair in webidsAndXPaths)
            {
                table.Rows.Add(location, objectName, pair.Key, pair.Value, dateTime);
            }

            // finally write the data to the sql server
            using (var bulkCopy = new SqlBulkCopy(conn))
            {
                conn.Open();
                bulkCopy.DestinationTableName = "dbo.ObjectInventory";
                bulkCopy.WriteToServer(table);
            }

Answer 2

Try to open and close the connection outside your loop, like this:

conn.Open();
foreach (var pair in webidsAndXPaths)
{
    //your code here
}
conn.Close();