Powershell递归失败？ 返回时清除变量

Question

I'm trying to create a list of "sentences" of 1-8 "words", provided a list of words, where I don't care about uniqueness as I can just filter out duplicates later. I decided that a recursive function would be the best method, particularly in case I wanted to change the maximum length at a later time.

When I ran this code, I came back with an empty result. When I debugged and stepped through it, I found that $sents would contain data right before a return statement, then have no data immediately after returned to the $sents variable in the first else statement.

This is the second recursive function I've written for PowerShell and neither worked. The first I ended up breaking down and wrote 4 nested foreach statements. This one would be 8 nested statements (I do not wish to do that) just to build a String array of sentences so I can process them.

Any help would be appreciated. Thank you!

function make-sentences ($ws, $ml, [String[]] $sent = @(), [String[]] $sents = @()) {
    [String[]] $nws = @()
    $sent += $ws[0]

if ($sent.length -ge $ml) {
    $sents += ($sent -join ",")
    return $sents
} elseif ($ws.length -le 1) {
    $sents += ($sent -join ",")
    return $sents
} else {
    for ($i = 1; $i -lt $ws.length; $i++) { $nws += $ws[$i] }
    $sents += make-sentences $nws $ml $sent $sents
}

[String[]] $nws = @()

if ($ws.length -le 1) {
    $sents += ($sent -join ",")
    return $sents
} else {
    $sent = @()
    for ($i = 1; $i -lt $ws.length; $i++) { $nws += $ws[$i] }
    $sents += make-sentences $nws $ml $sent $sents
}
}

$words = ("acfj","acfk","adfk","aefj","aefk","aegi","aehi","afgh")
[String[]] $sentences = make-sentences $words 8

$sentences

Answer 1

Sorry, I don't spent much time reading your code, but a thing you must know is that in PowerShell when you call a function the default behaviour for the parameters is the following (calling by argument):

function Dumy ($param1)
{
  $param1 = 100
  Write-Host "$param1 in function Dumy"
}


$param1 = 10
Write-Host "$param1 in main function before call to Dumy"
Dumy $param1
Write-Host "$param1 in main function after call to Dumy"

It gives:

10 in main function before call to Dumy
100 in function Dumy
10 in main function after call to Dumy

If you want to modify the value of your parameter, you should use a calling by reference:

function Dumy ([ref]$param1)
{
  $param1.value = 100
  Write-Host "$($param1.value) in function Dumy"
}


$param1 = 10
Write-Host "$param1 in main function before call to Dumy"
Dumy ([ref]$param1)
Write-Host "$param1 in main function after call to Dumy"

It gives:

10 in main function before call to Dumy
100 in function Dumy
100 in main function after call to Dumy

Another solution is to use the variable scope to modify the variable in a function in the calling scope (for me it's like using global variables).

Answer 2

I think your $sentences variable is empty, because your function - even if recursive - doesn't have a return statement. You have a return statement for terminal cases only, but you don't ask for a return statement when calling the function recursively. Then, your function returns something inside the call stack, but your main call is not asked to return anything.

Here are two example of recursive functions for factorial, the first one looks like your implementation, and does not return anything. Indeed, the recursive calls are stored in a variable, and then the function doesn't return anything. The second example does return something, because in every case, the function is asked to return a value, even through a recursive call :

function fact-Noresult ([int]$n, [int]$result=1){
  if ($n -eq 0) {
    Write-Host "returning now ! value = $result"
    return $result
  }else {
    $result = $n * (fact-Noresult ($n-1) ($result*$n))        
  }
}

function fact-WithResult ([int]$n, [int]$result=1){
  if ($n -eq 0) {
    return $result
  }else {
    $result=$n*$result
    fact-WithResult ($n-1) $result

  }
}

If you try to call them, you'll see that the first one display the message, and display the good value, but does not return it.