从varbinary case SQL Server C＃中读取图像

Question

I have a problem when I try to convert stream to image. It shows me an error in: Image returnImage = Image.FromStream(ms);

if (reader[12] != System.DBNull.Value)
{
    Byte[] image = (Byte[])reader[12];
    c.image = byteArrayToImage(image);
}

public Image byteArrayToImage(byte[] byteArrayIn)
{
    MemoryStream ms = new MemoryStream();
    ms.Write(byteArrayIn, 0, byteArrayIn.Length);
    ms.Seek(0, SeekOrigin.Begin);
    ms.Close();
    Image returnImage = Image.FromStream(ms);
    return returnImage;
}

Answer 1

You should not close the stream so soon :

   ms.Close();  // <- That's wrong:
   // You can't create an image from a disposed stream
   Image returnImage = Image.FromStream(ms); 

Do it like that:

  ...
  using (MemoryStream ms = new MemoryStream()) {
    ms.Write(byteArrayIn, 0, byteArrayIn.Length);
    ms.Seek(0, SeekOrigin.Begin);

    return Image.FromStream(ms);
  }

Answer 2

MemoryStream ms = new MemoryStream();
ms.Write(byteArrayIn, 0, byteArrayIn.Length);
ms.Seek(0, SeekOrigin.Begin);
ms.Close();  // <-- Remove this line

Image returnImage = Image.FromStream(ms);
return returnImage;

In this code you close the stream before creating the image. You can not read from a closed stream. Change your code to this:

using (MemoryStream ms = new MemoryStream(byteArrayIn))
{
    Image returnImage = Image.FromStream(ms);
    return returnImage;
}

That code may generate GDI+ errors. So you don't have to be afraid of not disposing of the stream at all. The garbage collector will do this anyway, so if you get errors in GDI+, use this:

MemoryStream ms = new MemoryStream(byteArrayIn);
Image returnImage = Image.FromStream(ms);
return returnImage;