使用2个表报告状态SQL查询

Question

I'm writing a report that brings back Landstatus's for our new clients. We have 3 options (Gold, Silver and Bronze and null if the user doesn't add there status). The data gets stored in 2 different tables dbo.tbl_Profile_ProjectLand and dbo.Tasks

At times i find that dbo.tbl_Profile_ProjectLand has a diffrent landstatus than dbo.Tasks

For my report i want to use the dbo.tbl_Profile_ProjectLand as my main table and if that doesn't have a result for landstatus then use the landstatus in the dbo.Tasks

The problem is that i cant seem to get the query right. here is my code.

SELECT 
Count
            ((CASE WHEN pp.landstatus > 0 THEN pp.landstatus
            ELSE t.landstatus END)) As Taken,
                ls.Description
FROM         dbo.Tasks AS t 
    LEFT JOIN
             tbl_User AS u 
    ON t.TakenBy = u.UserId 
    LEFT JOIN dbo.tbl_Profile_ProjectLand AS pp
ON t.Fk_ProfileID = pp.Fk_ProfileID
    LEFT JOIN
             tbl_DDLandStatus AS ls 
    ON t.LandStatus = ls.Id
    LEFT JOIN 
    dbo.tbl_EnquiryType AS e
    ON t.EnquiryType = e.EnquirytypeId
where
(Month(t.DueDate) = Month(getdate()) 
AND YEAR(t.DueDate) = YEAR(getdate ()))and t.EnquiryType = 1  
GROUP BY 
ls.Description 
ORDER BY ( CASE ls.Description
              WHEN 'Gold - owned' THEN 1
              WHEN 'Silver - identified / offered' THEN 2
              WHEN 'Bronze - no land' THEN 3
              ELSE 0
            END)

This brings back the following results

Taken   Description
40      NULL
34      Gold - owned
28      Silver - identified / offered
8       Bronze - no land

Now i have checked the 40 null result and this is not correct as there is Null value in the dbo.tbl_Profile_ProjectLand table and a 6 in the dbo.Tasks that represents a Bronze status.

I hope i have explained this OK as iv almost confused myself here. Any help would be greatly appreciated. Thanks

I have found a way to do this however i cant seem to group them. here is my new code

SELECT 
COUNT ((CASE WHEN pp.landstatus > 0 THEN pp.landstatus
            ELSE t.landstatus END)) As Taken,
((CASE WHEN ls.Description > '' THEN ls.Description
            ELSE lst.description END)) As 'Description'
FROM dbo.Tasks AS t 
LEFT JOIN tbl_DDLandStatus AS lst
    ON t.landstatus = lst.Id 
LEFT JOIN dbo.tbl_Profile_ProjectLand AS pp
    ON t.Fk_ProfileID = pp.Fk_ProfileID
LEFT JOIN tbl_DDLandStatus AS ls 
    ON pp.LandStatus = ls.Id
WHERE (Month(t.DueDate) = Month(getdate()) 
AND YEAR(t.DueDate) = YEAR(getdate ()))and t.EnquiryType = 1  
GROUP BY 
ls.Description,lst.description
ORDER BY ( CASE ls.Description
              WHEN 'Gold - owned' THEN 1
              WHEN 'Silver - identified / offered' THEN 2
              WHEN 'Bronze - no land' THEN 3
              ELSE 0
            END)

This brings back this result which is spot on but doesn't group.

Taken   Description
22      NULL
7       Bronze - no land
22      Gold - owned
14      Silver - identified / offered
5       Gold - owned
13      Gold - owned
7       Gold - owned
16      Silver - identified / offered
1       Silver - identified / offered
1       Silver - identified / offered
11      Silver - identified / offered

Any idea how i can get them grouped by description?

Answer 1

Can u modify the case like this and check

Select count(case when pp.landstatus is not null then pp.landstatus 
              ELSE t.landstatus END) as taken , your query

Answer 2

Changing the nature of the joins to accommodate the difference in status values is correct.

I think you will also find that you don't need the case expression in the COUNT()

All you need to do is tweak you most recent query in the group by to use the same case expression you use for the description column.

SELECT
      COUNT(*) as Taken
    , ((CASE
            WHEN ls.Description > ''
                  THEN ls.Description
            ELSE lst.description
      END)) AS 'Description'
FROM dbo.Tasks AS t
      LEFT JOIN tbl_DDLandStatus AS lst             ON t.landstatus = lst.Id
      LEFT JOIN dbo.tbl_Profile_ProjectLand AS pp   ON t.Fk_ProfileID = pp.Fk_ProfileID
      LEFT JOIN tbl_DDLandStatus AS ls              ON pp.LandStatus = ls.Id
WHERE (MONTH(t.DueDate) = MONTH(GETDATE())
      AND YEAR(t.DueDate) = YEAR(GETDATE()))
      AND t.EnquiryType = 1
GROUP BY
      (CASE
            WHEN ls.Description > ''
                  THEN ls.Description
            ELSE lst.description
      END)
ORDER BY
      (CASE ls.Description
            WHEN 'Gold - owned'
                  THEN 1
            WHEN 'Silver - identified / offered'
                  THEN 2
            WHEN 'Bronze - no land'
                  THEN 3
            ELSE 0
      END)

---

---

Below: previous attempt (fail): Not quite sure of these:

• there are 2 tables not referenced (required for the count?)
• the case expression is the equivalent of count(*), I think you need to NOT include the else, OR do "else NULL".

Try this:

SELECT
      COUNT
      (CASE
            WHEN pp.landstatus > 0
                  THEN pp.landstatus
      END)                             AS Taken
    , COALESCE(ls.Description, 'NULL') AS Description
FROM dbo.Tasks AS t
  LEFT JOIN tbl_User AS u                      ON t.TakenBy = u.UserId
  LEFT JOIN dbo.tbl_Profile_ProjectLand AS pp  ON t.Fk_ProfileID = pp.Fk_ProfileID
  LEFT JOIN tbl_DDLandStatus AS ls             ON t.LandStatus = ls.Id
  LEFT JOIN dbo.tbl_EnquiryType AS e           ON t.EnquiryType = e.EnquirytypeId
WHERE (MONTH(t.DueDate) = MONTH(GETDATE())
      AND YEAR(t.DueDate) = YEAR(GETDATE()))
      AND t.EnquiryType = 1
GROUP BY
      COALESCE(ls.Description, 'NULL')
ORDER BY
      (CASE ls.Description
            WHEN 'Gold - owned'
                  THEN 1
            WHEN 'Silver - identified / offered'
                  THEN 2
            WHEN 'Bronze - no land'
                  THEN 3
            ELSE 0
      END)