复杂功能的静态包装是否称为不良做法？

Question

I have a Factory Method that is relatively complex to call:

DatabaseAccessFactory.Instance.GetDatabaseAccess().GetUserData(userId) 
DatabaseAccessFactory.Instance.GetDatabaseAccess().InsertData(dataStr1,dataStr2);

To avoid having to call this large querys i wrant to wrap these calls in a static class:

public static class SQL
{
    public static User GetUserData(int userId)
    {
        return DatabaseAccessFactory.Instance.
            GetDatabaseAccess().GetUserData(userId);
    }
    public static void InsertData(String dataStr1, String dataStr2)
    {
        DatabaseAccessFactory.Instance.
            GetDatabaseAccess().InsertData(dataStr1,dataStr2);
    }
}

So that i could simply call:

SQL.GetUserData(userId) 
SQL.InsertData(dataStr1,dataStr2);

Is this considered bad practice?

Edit: Fixed Source

Answer 1

Your current solution only removes the Instance part out of the method call, a better alternative would be to completely remove the nested dot-notation eg

public static class SQL
{
    static IDatabase db = DatabaseAccessFactory.Instance.GetDatabaseAccess();

    public static User GetUserData(int userId)
    {
        return db.GetUserData(userId);
    }

    public static void InsertData(String dataStr1, String dataStr2)
    {
        db.InsertData(dataStr1, dataStr2);
    }
}

That way your usage would be

SQL.GetUserData(userId);
SQL.InsertData(dataStr1, dataStr2);

However, just be wary how you intend on using this code, sharing database connections application-wide can be troublesome, especially in a multi-threaded environment.