在每个循环的末尾添加字符串，但不为最后一个循环添加字符串

Question

I am creating a function to set query vars as below.

function set_query_var(array $params)
{
    $count = count($params);
    $query_var = '?';        

    foreach ( $params as $key => $value)
    {
        $query_var .= $key . '=' . $value .
        (($count > 1) ? '&' : NULL);
    }

    return $query_var;
}

Above function works fine but only issue is that, it is adding & to the end loop which I don't want.

How can I fix it?

Answer 1

I always use implode and array:

function set_query_var(array $params)
{
    $query_var = [];        

    foreach ($params as $key => $value) {
        $query_var[] = "{$key}={$value}";
    }

    return '?' . implode('&', $query_var);
}

Answer 2

An easy and dirty solution to you problem is to remove the last & from your string.

rtrim($string, "&");

would cut trailing & .

Answer 3

function set_query_var(array $params)
{
    $count = count($params);
    $query_var = '?';        

    foreach ( $params as $key => $value)
    {
        $query_var .= $key . '=' . $value .
        (($count > 1) ? '&' : NULL);
    }
    $query_var = rtrim( $query_var, "&");
    return $query_var;
}