将自定义对象添加到NSMutableArray

Question

I mainly program in Java and can't understand why this isn't working. I'm trying to create a temporary object "Judge" in my for loop. I then want to add that object to an NSMutableArray so in the end I have an array filled with different Judge objects. After the for loop I run through all the objects in the Array and they're all the last Judge Object.

The NSLog shows that "JudgeTemp" object is being assigned the right values while in the for loop. My guess is that it's not creating a new object called JudgeTemp every time but referencing the old already created JudgeTemp.

NSMutableArray *Judges = [NSMutableArray arrayWithCapacity:30];

for (int i=0; i<[courtinfoarray count]; i++) {
    Judge1= [[courtinfoarray objectAtIndex:i] componentsSeparatedByString:@"|"];

     Judge *JudgeTemp=[[Judge alloc]init];

    [JudgeTemp setName:[Judge1 objectAtIndex:0] picture:[Judge1 objectAtIndex:1] courtroom:[Judge1 objectAtIndex:2] phone:[Judge1 objectAtIndex:3] undergrad:[Judge1 objectAtIndex:4] lawschool:[Judge1 objectAtIndex:5] opdasa:[Judge1 objectAtIndex:6] career:[Judge1 objectAtIndex:7] judgecode:[Judge1 objectAtIndex:8]];

    NSLog(@"%@",[JudgeTemp getName]);
    [Judges addObject:JudgeTemp];
    NSLog(@"%@",[[Judges objectAtIndex:i]getName]);

}

Judges Class

@implementation Judge

NSString *name;
NSString *picture;
NSString *courtroom;
NSString *phone;
NSString *undergrad;
NSString *lawschool;
NSString *opdasa;
NSString *career;
NSString *judgecommentcode;


-(void) setName:(NSString *)n picture:(NSString *) p courtroom:(NSString *)c phone:(NSString *)ph undergrad: (NSString *) u lawschool: (NSString *)l opdasa: (NSString *) o career: (NSString *)ca judgecode: (NSString *)jcode{

name = n;
picture = p;
courtroom = c;
phone = ph;
undergrad = u;
lawschool = l;
opdasa = o;
career = ca;
judgecommentcode = jcode;

}
-(NSString*) getName{

return name;
}

Answer 1

The problem is with your Judge class. When you define variables directly in your @implementation they have global scope and are not instance variables. What you need to do is put those variable declarations in your @interface instead:

@interface Judge : NSObject {
    NSString *name;
    NSString *picture;
    NSString *courtroom;
    NSString *phone;
    NSString *undergrad;
    NSString *lawschool;
    NSString *opdasa;
    NSString *career;
    NSString *judgecommentcode;
}

// ...

@end

Edit: Apparently you can declare them in your @implementation , you just have to wrap them in { } . See: Instance variables declared in ObjC implementation file