数组和malloc之间的区别

Question

Here is my code :

#include<stdio.h>
#include <stdlib.h>

#define LEN 2

int main(void)
{

    char num1[LEN],num2[LEN];   //works fine with
                                //char *num1= malloc(LEN), *num2= malloc(LEN);
    int number1,number2;
    int sum;

    printf("first integer to add = ");
    scanf("%s",num1);

    printf("second integer to add = ");
    scanf("%s",num2);

    //adds integers
    number1= atoi(num1);
    number2= atoi(num2);
    sum = number1 + number2;

    //prints sum
    printf("Sum of %d and %d = %d \n",number1, number2, sum);

    return 0;
}

Here is the output :

first integer to add = 15
second integer to add = 12
Sum of 0 and 12 = 12

Why it is taking 0 instead of first variable 15 ?

Could not understand why this is happening.

It is working fine if I am using

char *num1= malloc(LEN), *num2= malloc(LEN);

instead of

char num1[LEN],num2[LEN];

But it should work fine with this.

Edited :

Yes, it worked for LEN 3 but why it showed this undefined behaviour . I mean not working with the normal arrays and working with malloc . Now I got that it should not work with malloc also. But why it worked for me, please be specific so that I can debug more accurately ?

Is there any issue with my system or compiler or IDE ?

Please explain a bit more as it will be helpful or provide any links to resources. Because I don't want to be unlucky anymore.

Answer 1

LEN is 2, which is enough to store both digits but not the required null terminating character. You are therefore overrunning the arrays (and the heap allocations, in that version of the code!) and this causes undefined behavior . The fact that one works and the other does not is simply a byproduct of how the undefined behavior plays out on your particular system; the malloc version could indeed crash on a different system or a different compiler.

Correct results, incorrect results, crashing, or something completely different are all possibilities when you invoke undefined behavior.

Change LEN to 3 and your example input would work fine.

I would suggest indicating the size of your buffers in your scanf() line to avoid the undefined behavior. You may get incorrect results, but your program at least would not crash or have a security vulnerability:

scanf("%2s", num1);

Note that the number you use there must be one less than the size of the array -- in this example it assumes an array of size 3 (so you read a maximum of 2 characters, because you need the last character for the null terminating character).

Answer 2

LEN is defined as 2. You left no room for a null terminator. In the array case you would overrun the array end and damage your stack. In the malloc case you would overrun your heap and potentially damage the malloc structures.

Both are undefined behaviour. You are unlucky that your code works at all: if you were "lucky", your program would decide to crash in every case just to show you that you were triggering undefined behaviour. Unfortunately that's not how undefined behaviour works, so as a C programmer, you just have to be defensive and avoid entering into undefined behaviour situations.

Why are you using strings, anyway? Just use scanf("%d", &number1) and you can avoid all of this.

Answer 3

Your program does not "work fine" (and should not "work fine") with either explicitly declared arrays or malloc -ed arrays. Strings like 15 and 12 require char buffers of size 3 at least. You provided buffers of size 2 . Your program overruns the buffer boundary in both cases, thus causing undefined behavior. It is just that the consequences of that undefined behavior manifest themselves differently in different versions of the code.

The malloc version has a greater chance to produce illusion of "working" since sizes of dynamically allocated memory blocks are typically rounded to the nearest implementation-depended "round" boundary (like 8 or 16 bytes). That means that your malloc calls actually allocate more memory than you ask them to. This might temporarily hide the buffer overrun problems present in your code. This produces the illusion of your program "working fine".

Meanwhile, the version with explicit arrays uses local arrays. Local arrays often have precise size (as declared) and also have a greater chance to end up located next to each other in memory. This means that buffer overrun in one array can easily destroy the contents of the other array. This is exactly what happened in your case.

However, even in the malloc -based version I'd still expect a good debugging version of standard library implementation to catch the overrun problems. It is quite possible that if you attempt to actually free these malloc -ed memory blocks (something you apparently didn't bother to do), free will notice the problem and tell you that heap integrity has been violated at some point after malloc .

PS Don't use atoi to convert strings to integers. Function that converts strings to integers is called strtol .