在PowerShell中传递PortQry参数

Question

I'm trying to verify the correct firewall rules have been implemented and flows are functional. I've searched and can't seem to find my solution. I'm using PowerShell to automate PortQry requests (based on it's role) for list of servers which seems simple. But I cannot seem to pass the arguments correctly to PortQry and end up with the PortQry help screen.

Here is my function:

  Function CheckPorts($x,$y,$z) {
    PortQry -n $x -p $y -o $z | Out-File $ResultsFile -Append
    }

And here is my ForEach loop that I'm using to iterate through an array created by and imported CSV:

  $Type = TCP      
   Foreach ($Server in $ServerRoleArray.Role1) {
            if ($Server -ne "") {
            CheckPorts $Server $Type $Role1Ports
        }

Added information: It appears as though I'm not extracting $Server variable correctly from the array. Here is my import:

$ServerRoleArray = Import-CSV $FilePath\Servers.csv

My Servers.csv looks like:

Role1,Role2
google.com,msn.com
yahoo.com,

Thoughts?? BTW I've tried this in powershell v2 & v3

Answer 1

Im sure this is an issue of the command line parameters being sent to PortQry not looking like you would expect them to be. I still don't know what your $Role1Ports looks like so that might be the source of your woes. Making an assumtion that you have it declared like this $Role1Ports = "80,443"

Function CheckPorts($x,$y,$z) {
    PortQry -n $x -p $y -o `"$z`" | Out-File $ResultsFile -Append
}

$ServerRoleArray = Import-Csv C:\temp\server.tkt.txt
$Role1Ports = "80,443"

$Type = "TCP"      
Foreach ($Server in $ServerRoleArray.Role1) {
    if ($Server -ne "") {
    CheckPorts $Server $Type $Role1Ports
    }
}

Needed to puts quotes on "TCP" so that it would be interpreted as a string. Nothing is wrong with your ForEach loop that i can see. I used your test example data and it processed fine. I wrapped up $z in the CheckPorts function so that the ports in z$ should be passed properly as well. That was done as per the examples of PortQry i found online

If your $Role1Ports looked like this instead: $Role1Ports = 80,443 or was in some form of array then you could do either of these and the code I used above would work still.

$Role1Ports = $Role1Ports -join ","

or

$Role1Ports = 80,443 -join ","

The command output that you should get is something like this.

PortQry -n google.com -p TCP -o "80,443"
PortQry -n yahoo.com -p TCP -o "80,443"

Because of other answer

I dont know why you had issues with you logic since it was working fine. Based on your comments i used a different text file.

Role1,Role2
,msn.com
google.com,
yahoo.com,

Even with the the if ($Server -ne "") statement it still worked. if ($Server) would also have worked.

Answer 2

My ForEach loop was wrong. 2 problems existed: first, the null check was not correct and the call for the column was not correct. This is the correct loop:

ForEach ($Server in $ServerRoleArray) {
    if (!$Server.Role1) {
    break
    } else {
    CheckPorts $Server.Role1 "TCP" $Role1Ports
    }
}