在php中关闭元素标签

Question

I have just started to learn PHP from books and have come across something I don't understand. In the book they never close html tags is this correct practice or should they be closed? Here is an example of the books content:

    <?php

        $cars = array('Dodge'=>'Viper','Chevrolet'=>'Camaro','Ford'=>'Mustang');
        echo '<dl><dt>Original Element Order:<dd>';
        foreach($cars as $key => $value){
            echo '&bull;', $key.' '.$value;
        }

    ?>

Could anyone tell me if this is correct and common practice? Thanks

Answer 1

Some old books :). They definitely need to be closed. You need to echo </dd></dt></dl> after the foreach loop.

Answer 2

The end tags for the <dt> and <dd> elements are optional in HTML. The missing </dl> is a problem though.

Other issues with this fragment:

• Using • for a list instead of list markup
• Using something that looks like a <ul> (but is simulated with • ) for key/value pairs
• Having a dl with only one dt in it.