对于失败的文件解析，我应该抛出什么异常？

Question

I have a method parsing a file. However, this parsing could fail anytime, depending on various conditions (not-so-cautious user playing with the file, for example).

public string ParseDatFile(string datFile)
{
    string[] deezLines = File.ReadAllLines(datFile);

    // We're searching for an essential data inside the file.
    bool daEssentialDataFound = false;
    foreach (string datLine in deezLines)
    {
        if (datLine.Contains("daEssentialData"))
        {
            daEssentialDataFound = true;
            break;
        }
    }

    if (!daEssentialDataFound)
        throw new WhatShouldIThrowException("yo dood where's da essential data in " + datFile + "?");

    DoStuffWith(deezLines);
}

Is there an exception I could use in such a scenario? I thought about:

• FormatException : not really clear about the issue,
• Custom exception : I do not have any special treatment for the exception I'm throwing, so I'd rather avoid using a custom exception, even though that's always a way to settle things down.

Answer 1

FileFormatException should be fine :

The exception that is thrown when an input file or a data stream that is supposed to conform to a certain file format specification is malformed.

You can optionally provide the uri and a descriptive error message.

---

If you don't want to reference WindowsBase then you may create your own exception specific to your format. Based on the fact there is an XmlException thrown by XmlReader.Read .

Answer 2

I would throw a custom exception since that increases readability and allows to catch that specifc exception:

public class InvalidFileFormatException : System.FormatException
{
    public InvalidFileFormatException(string exText) : base(exText) { }
}

// you could even provide an exception if a single line has an invalid format
public class SpecificLineErrorException : InvalidFileFormatException 
{
    public string Line { get; set; }
    public SpecificLineErrorException(string exText, string line) : base(exText) 
    {
        this.Line = line;
    }
}

Now your method can look like(also linqified it a little bit:

public string ParseDatFile(string datFile)
{
    string[] deezLines = File.ReadAllLines(datFile);
    if(!deezLines.Any(l => l.Contains("daEssentialData")))
        throw new InvalidFileFormatException("yo dood where's da essential data in " + datFile + "?");
    DoStuffWith(deezLines);
}